From owner-cvs-all Thu Nov 14 17:36:41 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F77137B401; Thu, 14 Nov 2002 17:36:40 -0800 (PST) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 196C243E3B; Thu, 14 Nov 2002 17:36:40 -0800 (PST) (envelope-from eischen@pcnet1.pcnet.com) Received: from localhost (eischen@localhost) by mail.pcnet.com (8.12.3/8.12.1) with ESMTP id gAF1acMc025900; Thu, 14 Nov 2002 20:36:38 -0500 (EST) Date: Thu, 14 Nov 2002 20:36:38 -0500 (EST) From: Daniel Eischen To: Archie Cobbs Cc: Archie Cobbs , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc_r/uthread uthread_execve.c In-Reply-To: <200211150116.gAF1GEhq032365@arch20m.dellroad.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 14 Nov 2002, Archie Cobbs wrote: > Daniel Eischen wrote: > > > Modified files: > > > lib/libc_r/uthread uthread_execve.c > > > Log: > > > When about to do an execve(), don't reset the O_NONBLOCK flag on any file > > > descriptors that have the close-on-exec flag set, as that will have no > > > effect anyway and might screw something else up if the file descriptor > > > happens to be shared with another process. > > > > I didn't like this change. It was a hack to cover up some other > > problem. > > But it was harmless, right? I figured it fixes some corner case without > causing any additional bugs so why not? Yes, but might help to hide what the real problem is (if there is one). > The real underlying problem doesn't seem solvable; I'd rather wait > until libc_r is KSE'ified. I don't envision that. That's what libpthread is for. Death to libc_r, death to them all... :-) -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message