Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Nov 2002 20:36:38 -0500 (EST)
From:      Daniel Eischen <eischen@pcnet1.pcnet.com>
To:        Archie Cobbs <archie@dellroad.org>
Cc:        Archie Cobbs <archie@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libc_r/uthread uthread_execve.c
Message-ID:  <Pine.GSO.4.10.10211142034280.25390-100000@pcnet1.pcnet.com>
In-Reply-To: <200211150116.gAF1GEhq032365@arch20m.dellroad.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 14 Nov 2002, Archie Cobbs wrote:

> Daniel Eischen wrote:
> > >   Modified files:
> > >     lib/libc_r/uthread   uthread_execve.c 
> > >   Log:
> > >   When about to do an execve(), don't reset the O_NONBLOCK flag on any file
> > >   descriptors that have the close-on-exec flag set, as that will have no
> > >   effect anyway and might screw something else up if the file descriptor
> > >   happens to be shared with another process.
> > 
> > I didn't like this change.  It was a hack to cover up some other
> > problem.
> 
> But it was harmless, right? I figured it fixes some corner case without
> causing any additional bugs so why not?

Yes, but might help to hide what the real problem is (if there is one).

> The real underlying problem doesn't seem solvable; I'd rather wait
> until libc_r is KSE'ified.

I don't envision that.  That's what libpthread is for.  Death to
libc_r, death to them all...  :-)

-- 
Dan Eischen


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.10.10211142034280.25390-100000>