From owner-svn-src-head@freebsd.org Wed May 8 15:39:59 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75BE8158A976 for ; Wed, 8 May 2019 15:39:59 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 009DA80ACF for ; Wed, 8 May 2019 15:39:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82a.google.com with SMTP id o7so1623618qtp.4 for ; Wed, 08 May 2019 08:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+5zbKeg4Emwcw7mMAM9phxj5CHmlKP+OUTJvEXvLaPQ=; b=gh0quBRC2aYKLR6hRChf8SYi9woUzbqN56INHQm9Ka4LKskv9ZraWOy7BJZgwe2F8X d3J1ccBhKYD00KfoUtEfNGaimJmuknMgGGzinOFnlx2ouknkGB+2/E5vXbA1yXbYpLlx JzZJbDroh3gJpKn1Np4a0DPE94+IgEwGjkExDaF65p29KDJwGUg4QY6lSoahwGOB07tx P+FqdGRGZxALeoi6FHpR752DerTquWsQLGbh6cZWEdvRUykBQlOBaizcmV1VQyhB+ppx lWZ5JFNmTTWg6mN19zvGvru69y6AYJxYk/GFjw2D0byFFQN7LD54JnRb7VVdR08q7Mzt g4Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+5zbKeg4Emwcw7mMAM9phxj5CHmlKP+OUTJvEXvLaPQ=; b=VvCjfHPaKYKZrl1x7DVT941zw4OKzZE9vbYqlyTzQK1PaS3DMIsXwwtqtKdpXCy7WD BTlMCgqtyd4ynwSil3Z4YGdhYTwyKvD32njT9H2S4EUGpnNnIRC4buILOoCTtmmmAp8P JSNkFD8wyrflp5xyXy99UdZPYqGoK4nTV6I+RHcz/HEpHEd7ktSU0qJtP37jWYZs5p6k WwdIWQu/HU6UiRe8C+irwi7Gul1FOT2iIxtxTlGO+VyG5RympKOOVjwGpFiZ05mDDKa3 70/24jgqwmduhKUMGly3pJnIEW1/hLY2k7Io9VO8tZq4lo1yejrgafmLz4Uflihjbh1w kSIw== X-Gm-Message-State: APjAAAVdRb0gx5171kV/uOXEwKS+eZnUKJfI26LC44feKEBsUL2NStmg T5E4BnI6YglRTh84ynzJFmtoBxXfrIcUSMsx43fbVA== X-Google-Smtp-Source: APXvYqzowqLLTP76KIxBZaBYyyoB4taHxc5t2R8aQ9KaVyrWr8r77GC/FfxABCPsTY2VDXLxB3vgAbiOTGzNMsWWLCo= X-Received: by 2002:ac8:875:: with SMTP id x50mr13696755qth.345.1557329997216; Wed, 08 May 2019 08:39:57 -0700 (PDT) MIME-Version: 1.0 References: <201905070508.x4758DW5015688@repo.freebsd.org> <201905070531.x475VuIY010069@gndrsh.dnsmgr.net> <57ea4a23-c78e-1871-e06b-baf4f78882fd@FreeBSD.org> In-Reply-To: <57ea4a23-c78e-1871-e06b-baf4f78882fd@FreeBSD.org> From: Warner Losh Date: Wed, 8 May 2019 09:39:46 -0600 Message-ID: Subject: Re: svn commit: r347218 - head/sys/compat/linsysfs To: Renato Botelho Cc: Dmitry Chagin , "Rodney W. Grimes" , svn-src-head , svn-src-all , src-committers X-Rspamd-Queue-Id: 009DA80ACF X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=gh0quBRC X-Spamd-Result: default: False [-5.96 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[ALT1.aspmx.l.google.com,aspmx.l.google.com,ALT2.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[a.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.99)[-0.986,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-2.97)[ip: (-9.31), ipnet: 2607:f8b0::/32(-3.21), asn: 15169(-2.25), country: US(-0.06)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 May 2019 15:39:59 -0000 On Tue, May 7, 2019 at 4:45 AM Renato Botelho wrote: > On 07/05/19 02:45, Dmitry Chagin wrote: > > =D0=B2=D1=82, 7 =D0=BC=D0=B0=D1=8F 2019 =D0=B3. =D0=B2 08:32, Rodney W.= Grimes : > > > >>> Author: dchagin > >>> Date: Tue May 7 05:08:13 2019 > >>> New Revision: 347218 > >>> URL: https://svnweb.freebsd.org/changeset/base/347218 > >>> > >>> Log: > >>> Remove wrong copyright line. Discussed with Carlos Neira. > >>> > >>> Reported by: Rodney W. Grimes > >> normally just use a committers username, aka rgrimes or rgrimes@ > >> for these types of things. > >> > >> > > ah, I see only: Rodney W. Grimes > > > > > > > >>> MFC after: 2 weeks > >>> Differential Revision: https://reviews.freebsd.org/D13656 > >> > >> Hang on, now you removed his copyright? > >> I see he said that was ok, but that was not the desired intent here. > >> It would of been fine to have the copyright read: > >> > >> * Copyright (c) 2006 IronPort Systems > >> * All rights reserved. > >> * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com > >> > >> As a heads up to other committers you should never insert your > >> copyright between another copyright and the "All rights reserved." tex= t, > >> if you wish to assert the all rights reserved you should duplicate > >> it like: > >> > >> * Copyright (c) 2006 IronPort Systems > >> * All rights reserved. > >> * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com > >> * All rights reserved. > >> > >> preferably on the line with your copyright as in: > >> * Copyright (c) 2017 Carlos Neira cneirabustos@gmail.com All rights > >> reserved. > >> > >> But if at all possible it would be best if we could not add any > >> more of these, and remove them when possible. > >> > >> > > and that actually I did. thanks > > Rod was saying to remove "All rights reserved" when possible, not the > Copyright line. > No. He's saying 'Add the copyright line after the all rights reserve line so we can start cleaning that mess up.' Don't just remove 'All Rights Reserved from old copyright notices. Warner