From owner-cvs-all@FreeBSD.ORG  Thu May  1 01:42:48 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BFE0C37B401; Thu,  1 May 2003 01:42:48 -0700 (PDT)
Received: from critter.freebsd.dk (esplanaden.cybercity.dk [212.242.40.114])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9036743FAF; Thu,  1 May 2003 01:42:47 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h417dVLd000772;
	Thu, 1 May 2003 09:39:31 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: Mike Barcroft <mike@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 30 Apr 2003 18:43:51 EDT."
             <20030430184351.B31859@espresso.bsdmike.org> 
Date: Thu, 01 May 2003 09:39:31 +0200
Message-ID: <771.1051774771@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Mark Murray <markm@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/i386 identcpu.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 May 2003 08:42:49 -0000

In message <20030430184351.B31859@espresso.bsdmike.org>, Mike Barcroft writes:
>Mark Murray <markm@FreeBSD.org> writes:
>> markm       2003/04/30 05:23:58 PDT
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/i386/i386        identcpu.c 
>>   Log:
>>   Warns fixing. Protect against inappropriate linting, and mark
>>   GCC-specific assemble code as such (in #ifdefs). Fix an easy
>>   static variable warning while I'm here.
>>   
>>   Revision  Changes    Path
>>   1.122     +8 -1      src/sys/i386/i386/identcpu.c
>
>Is it really useful to #ifdef critical sections of code.  This thing
>isn't going to compile without asm extentions from the compiler.  So
>really you just turn compile errors into link error.  Not very helpful
>IMO.

Yes, it is useful, because it allows us to run code validation tools
on our source code.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.