From owner-cvs-all@FreeBSD.ORG  Thu Jun 19 12:12:14 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4E66837B401; Thu, 19 Jun 2003 12:12:14 -0700 (PDT)
Received: from demos.su (mx.demos.su [194.87.0.32])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 12F9343F85; Thu, 19 Jun 2003 12:12:12 -0700 (PDT)
	(envelope-from mitya@fling-wing.demos.su)
Received: from [194.87.5.69] (HELO fling-wing.demos.su)
  by demos.su (CommuniGate Pro SMTP 4.1b7/D)
  with ESMTP-TLS id 76680907; Thu, 19 Jun 2003 23:12:10 +0400
Received: from fling-wing.demos.su (localhost [127.0.0.1])
	by fling-wing.demos.su (8.12.9/8.12.6) with ESMTP id h5JJCA5R097717;
	Thu, 19 Jun 2003 23:12:10 +0400 (MSD)
	(envelope-from mitya@fling-wing.demos.su)
Received: (from mitya@localhost)
	by fling-wing.demos.su (8.12.9/8.12.6/Submit) id h5JJC8fU097715;
	Thu, 19 Jun 2003 23:12:08 +0400 (MSD)
Date: Thu, 19 Jun 2003 23:12:08 +0400
From: Dmitry Sivachenko <demon@freebsd.org>
To: John-Mark Gurney <gurney_j@efn.org>
Message-ID: <20030619191208.GA97562@fling-wing.demos.su>
References: <200306181857.h5IIvwfY075070@repoman.freebsd.org>
	<20030619082713.GC79448@HAL9000.homeunix.com>
	<20030619115532.A629@odysseus.silby.com>
	<20030619150711.GA56423@fling-wing.demos.su>
	<20030619140309.H629@odysseus.silby.com> <20030619182213.GB64061@funkthat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20030619182213.GB64061@funkthat.com>
WWW-Home-Page: http://mitya.pp.ru/
X-PGP-Key: http://mitya.pp.ru/mitya.asc
User-Agent: Mutt/1.5.4i
cc: cvs-src@freebsd.org
cc: Mike Silbersack <silby@silby.com>
cc: src-committers@freebsd.org
cc: David Schultz <das@freebsd.org>
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/kern kern_descrip.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jun 2003 19:12:14 -0000

On Thu, Jun 19, 2003 at 11:22:13AM -0700, John-Mark Gurney wrote:
> Mike Silbersack wrote this message on Thu, Jun 19, 2003 at 14:03 -0500:
> > 
> > On Thu, 19 Jun 2003, Dmitry Sivachenko wrote:
> > 
> > > > Oh, btw; while running my fd hog program as root, cron decided to core.
> > > > Someone should take a look at it and figure out where it doesn't check the
> > > > return value of something which allocates a fd (or socket?)
> > > >
> > >
> > > bin/49096 ?
> > 
> > That looks like it might be it, I'll give it a try and commit it if solves
> > the problem for me.
> 
> Actually, that patch should be committed even if it doesn't solve the
> problem.  The if (in == NULL) is useless since we already tried to
> read a char from it.
> 

I tested it before submitting trying to reproduce symptoms desctibed in 
the PR.  This patch solved the problem for me.

FYI.