From owner-cvs-all@FreeBSD.ORG Sat Dec 18 19:06:37 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69F7B106566C; Sat, 18 Dec 2010 19:06:37 +0000 (UTC) (envelope-from mi+thun@aldan.algebra.com) Received: from vms173019pub.verizon.net (vms173019pub.verizon.net [206.46.173.19]) by mx1.freebsd.org (Postfix) with ESMTP id 3FCA38FC13; Sat, 18 Dec 2010 19:06:36 +0000 (UTC) Received: from [192.168.1.8] ([unknown] [173.70.194.135]) by vms173019.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0LDN001B812KQS94@vms173019.mailsrvcs.net>; Sat, 18 Dec 2010 13:06:25 -0600 (CST) Message-id: <4D0D0617.90207@aldan.algebra.com> Date: Sat, 18 Dec 2010 14:05:59 -0500 From: "Mikhail T." User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; uk-UA; rv:1.9.2.12) Gecko/20101114 Thunderbird/3.1.6 MIME-version: 1.0 To: Doug Barton References: <201012140611.oBE6B42j028412@repoman.freebsd.org> <4D0BD30B.8030708@FreeBSD.org> In-reply-to: <4D0BD30B.8030708@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports GIDs UIDs ports/net Makefile ports/net/minidlna Makefile distinfo pkg-descr pkg-plist ports/net/minidlna/files BSDmakefile config.h getifaddr.c minidlna.sh.in patch-2928850 patch-aa patch-ab patch-inline patch-minidlna.c patch-upnphttp ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Dec 2010 19:06:37 -0000 On 17.12.2010 16:15, Doug Barton wrote: > In no particular order, new rc.d scripts should not be added with the > .sh extension. I've attached a patch to the current version, but when > the final result is committed it should be minidlna.in. Thanks for the diff, Doug. Regarding the .sh extension, there is a problem... This port has NO_WRKSUBDIR, and its main executable itself is called minidlna. If I don't use the .sh extension, the script overwrites the binary in WRKDIR (which is the same as WRKSRC in this case). The explicit PID-file removal was necessary, because I patched the software to drop root-privileges after creating the PID-file and opening its log (under /var/log). If the PID file is not removed before a subsequent start, the program will not overwrite it -- unlike rc.subr, it has no smarts to figure out, the PID-file is stale. Now, in my defense, FWIW, I used the net/mediatomb's rc.d script as a working (and accepted) example... Sorry, didn't realize the significance of the KEYWORD comment... And I remind, again, that I asked publicly -- on ports@ -- for help in creating the start-up script six months ago. No one has volunteered and I figured, it is better to have a port with imperfect start-up script, than no port at all... Yours, -mi