From owner-cvs-all@FreeBSD.ORG Sun Feb 24 17:57:29 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D006016A404; Sun, 24 Feb 2008 17:57:29 +0000 (UTC) (envelope-from kaiw@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id AC3F513C447; Sun, 24 Feb 2008 17:57:29 +0000 (UTC) (envelope-from kaiw@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m1OHvTOU067367; Sun, 24 Feb 2008 17:57:29 GMT (envelope-from kaiw@repoman.freebsd.org) Received: (from kaiw@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m1OHvTfT067366; Sun, 24 Feb 2008 17:57:29 GMT (envelope-from kaiw) Message-Id: <200802241757.m1OHvTfT067366@repoman.freebsd.org> From: Kai Wang Date: Sun, 24 Feb 2008 17:57:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/ar write.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Feb 2008 17:57:29 -0000 kaiw 2008-02-24 17:57:29 UTC FreeBSD src repository Modified files: usr.bin/ar write.c Log: Handle properly when insert zero size objects into the archive: Do not mmap 0-size objects and do not try to extract symbol from 0-size objects, but do treat 0-size objects as qualified objects and accept them as an archive member. (A member with only the header part) Note that GNU binutils ar on FreeBSD ignores 0-size objects, but on Linux it accepts them. [1] But, since this is a rare usage, we can safely ignore the compatibility issue. Reported by: Michael Plass Pointed out by: Michael Plass [1] Reviewed by: Michael Plass Reviewed by: jkoshy Approved by: jkoshy (mentor) Revision Changes Path 1.2 +9 -3 src/usr.bin/ar/write.c