From owner-cvs-all Fri Nov 30 14:51:19 2001 Delivered-To: cvs-all@freebsd.org Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by hub.freebsd.org (Postfix) with ESMTP id 35FA837B417; Fri, 30 Nov 2001 14:51:12 -0800 (PST) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.9.3/8.9.3) with ESMTP id RAA26076; Fri, 30 Nov 2001 17:51:07 -0500 (EST) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.11.3/8.9.1) id fAUMofc00875; Fri, 30 Nov 2001 17:50:41 -0500 (EST) (envelope-from gallatin@cs.duke.edu) Date: Fri, 30 Nov 2001 17:50:41 -0500 From: Andrew Gallatin To: Luigi Rizzo Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dc.c if_sis.c Message-ID: <20011130175040.A836@grasshopper.cs.duke.edu> References: <200111292347.fATNllI06694@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200111292347.fATNllI06694@freefall.freebsd.org>; from luigi@FreeBSD.org on Thu, Nov 29, 2001 at 03:47:47PM -0800 X-Operating-System: FreeBSD 4.3-RELEASE on an i386 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Luigi Rizzo [luigi@FreeBSD.org] wrote: > luigi 2001/11/29 15:47:47 PST > > Modified files: > sys/pci if_dc.c if_sis.c > Log: > Per jlemon request, reintroduce some printf() when an > mbuf allocation fails, and fix (i hope) a couple of style bugs. > > I believe these printf() are extremely dangerous because now they can > occur on every incoming packet and are not rate limited. They were > meant to warn the sysadmin about lack of resources, but now they > can become a nice way to panic your system under load. I agree 100%. I've seen messages like this from if_ti swamp a serial console so badly that its faster to reset the machine than to wait for the messages to finish printing.. > Other drivers (e.g. the fxp driver) have nothing like this. Most of the gig drivers have this misfeature too. > There is a pending discussion on putting this kind of warnings > elsewhere, and I hope we can fix this soon. Good.. Some sort of log-scaled limit printf would be good. Drew To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message