From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Dec 28 03:10:01 2012 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 07A69E6A for ; Fri, 28 Dec 2012 03:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id B92AB8FC12 for ; Fri, 28 Dec 2012 03:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qBS3A0Dp094833 for ; Fri, 28 Dec 2012 03:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qBS3A0Vm094827; Fri, 28 Dec 2012 03:10:00 GMT (envelope-from gnats) Resent-Date: Fri, 28 Dec 2012 03:10:00 GMT Resent-Message-Id: <201212280310.qBS3A0Vm094827@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gerald Pfeifer Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E4B7EE28 for ; Fri, 28 Dec 2012 03:04:01 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66]) by mx1.freebsd.org (Postfix) with ESMTP id C06AD8FC0C for ; Fri, 28 Dec 2012 03:04:01 +0000 (UTC) Received: from [192.168.173.80] (231.243.3.202.dsl.dyn.mana.pf [202.3.243.231]) by ainaz.pair.com (Postfix) with ESMTPSA id 48A023F478 for ; Thu, 27 Dec 2012 22:03:56 -0500 (EST) Message-Id: Date: Thu, 27 Dec 2012 17:03:31 -1000 (TAHT) From: Gerald Pfeifer To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/174758: ports-mgmt/portlint: support USE_GCC=yes X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2012 03:10:01 -0000 >Number: 174758 >Category: ports >Synopsis: ports-mgmt/portlint: support USE_GCC=yes >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Dec 28 03:10:00 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Gerald Pfeifer >Release: >Organization: >Environment: >Description: A few days ago, we added USE_GCC=yes as another (and now preferred form of USE_GCC). The patch below is a strawman of getting this supported by portlint. I went ahead and made USE_GCC=any and USE_GCC=yes a distinct check, so that we can become stricter in filtering unsupported options of USE_GCC later on that someone might use. >How-To-Repeat: >Fix: --- portlint.pl 2012-12-28 02:29:16.000000000 +0100 +++ portlint.new 2012-12-28 02:28:58.000000000 +0100 @@ -2035,7 +2035,9 @@ if ($whole =~ /^USE_GCC[?:]?=\s*(.*)$/m) { my $lineno = &linenumber($`); my $gcc_val = $1; - if ($gcc_val =~ /3\.[234]\+/) { + if ($gcc_val eq 'any' || $gcc_val eq 'yes') { + # Just accept these two. + } elsif ($gcc_val =~ /3\.[234]\+/) { &perror("WARN", $file, $lineno, "USE_GCC=3.2+, USE_GCC=3.3+, ". "and USE_GCC=3.4+ are noops on all currently (and future) ". "supported versions of FreeBSD. Do not use them."); >Release-Note: >Audit-Trail: >Unformatted: