From owner-freebsd-hackers@freebsd.org Thu Dec 7 03:57:05 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FA68E9B256 for ; Thu, 7 Dec 2017 03:57:05 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id EF9B3740BF; Thu, 7 Dec 2017 03:57:04 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id vB73v4Jv055064 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 6 Dec 2017 19:57:04 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id vB73v4DI055063; Wed, 6 Dec 2017 19:57:04 -0800 (PST) (envelope-from sgk) Date: Wed, 6 Dec 2017 19:57:04 -0800 From: Steve Kargl To: Pedro Giffuni Cc: FreeBSD Hackers Subject: Re: SPDX tags in file? Message-ID: <20171207035704.GA54501@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <4247a923-a297-1626-a576-a13651da90ab@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4247a923-a297-1626-a576-a13651da90ab@FreeBSD.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 03:57:05 -0000 On Wed, Dec 06, 2017 at 09:17:06PM -0500, Pedro Giffuni wrote: > > > It seems that the application of SPDX license tags > > has been automated and done without reviewing whether > > the tag is correct. For example, the BSD-4-Clause > > tag has been placed in the files in lib/msun/bsdsrc. > > Given the UCB letter concerning removal of clauses > > 3 and 4, these files should probably have had the > > Copyright updated and a different SPDX clause applied. > > > > -- > > Steve > > The initial sweep was done manually, but as you might have noticed, it > covered a lot of files and mistakes are certainly possible. > > The idea at this time is/was not to replace licenses: I am not a lawyer > but I think we may have to look at who has touched a file before doing > any license change. That may be a complex process. > > This said. checking for bsd-4-clause is a pretty good opportunity to > review and modernize code. If the code comes from another BSD (and > particularly NetBSD as I noticed during the sweep), it is likely > upstream has updated the license as well and there may be interesting > changes involved. > Not all revisions apply to all four files r1573 rgrimes BSD 4.4 Lite r8870 rgrimes Trailing whitespace r84210 dillon Add __FBSDID r92887 obrien Fix SCM ID's r92917 obrien Remove __P() usage. r93211 bde Resurrect Lite1 r97407 keramida Assume __STDC__ r108533 schweikh Typos and whitespace r129312 stefanf Remove some kludges (use C99 hexadecimal constant) r138924 das Cosmetic changes only r138925 das GC unused declaration r150318 bde Fixed aliasing bugs in TRUNC() r152566 bde Removed an unused declaration and style bugs r169209 bde Document current (slightly broken) handling of special values r169212 bde Fix tgamma() on some special args r176449 das Eliminate some warnings r226414 das Fix some non-standard variable declarations. r325966 pfg spdx If you don't count UCB as upstream (aka r1573), then FreeBSD is upstream. Looking at NetBSD the commit message for b_tgamma.c is "Add tgamma{,f} from FreeBSD via rudolf, netbsd at eq dot cz". OpenBSD is a little more complicated, but its initial version appeared in 2008 while FreeBSD's appeard in 1994. IMHO (non-lawyer) opinion, the only thing that might rise to the level of Copyright-able material would be r169212. Bruce did not add his name as he has done elsewhere. BTW, OpenBSD uses a 3-clause BSD license. -- Steve