From owner-svn-src-head@freebsd.org Mon Apr 16 12:05:53 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2037FA48F1; Mon, 16 Apr 2018 12:05:53 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660087.outbound.protection.outlook.com [40.107.66.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F8A86C5C9; Mon, 16 Apr 2018 12:05:52 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM (52.132.66.153) by YQBPR0101MB1073.CANPRD01.PROD.OUTLOOK.COM (52.132.66.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.675.9; Mon, 16 Apr 2018 12:05:51 +0000 Received: from YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM ([fe80::893c:efc2:d71f:945a]) by YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM ([fe80::893c:efc2:d71f:945a%13]) with mapi id 15.20.0675.015; Mon, 16 Apr 2018 12:05:51 +0000 From: Rick Macklem To: Julian Elischer , Konstantin Belousov , Andriy Gapon CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r332559 - head/usr.sbin/mountd Thread-Topic: svn commit: r332559 - head/usr.sbin/mountd Thread-Index: AQHT1WPJF2YW/FdX9EeBNLw0aDyfeKQDOEiAgAAHNYCAAApiFQ== Date: Mon, 16 Apr 2018 12:05:51 +0000 Message-ID: References: <201804160917.w3G9HaCN081290@repo.freebsd.org> <20180416105611.GG1774@kib.kiev.ua>, <5e754f1f-9688-884a-cddd-fa4b65e67f0b@freebsd.org> In-Reply-To: <5e754f1f-9688-884a-cddd-fa4b65e67f0b@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YQBPR0101MB1073; 7:sWuwQzBF1aEi4Ur6w3l4LE4YvAfRCfAfVtYDMi2TMhG0QmlwdLeThonFT84M4GlzEqoUMuwGjHNhzrgFr6aBSnNJcOqJykMA+gB+eJXZIKrMePdx0GyWz6OupKuRMkrVVC1CgSwa/uiZkkso3n93KPkLRBsOPq4bvdo7m6xaK7GLueTwCcX0qzYq9IOeRuMI/+U0e21fiWY4dE5SCTA0whHYdfyU0MXiNzzhJWfODzf6SXF3bEw/zP8z3BjBWtXc x-ms-exchange-antispam-srfa-diagnostics: SOS; x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989080)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(8990040)(2017052603328)(7153060)(7193020); SRVR:YQBPR0101MB1073; x-ms-traffictypediagnostic: YQBPR0101MB1073: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231232)(944501327)(52105095)(93006095)(93001095)(3002001)(6041310)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:YQBPR0101MB1073; BCL:0; PCL:0; RULEID:; SRVR:YQBPR0101MB1073; x-forefront-prvs: 0644578634 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(39380400002)(396003)(39860400002)(199004)(189003)(316002)(81156014)(81166006)(5660300001)(97736004)(11346002)(86362001)(476003)(8676002)(786003)(68736007)(446003)(106356001)(105586002)(99286004)(2900100001)(3660700001)(25786009)(486006)(186003)(305945005)(26005)(7696005)(76176011)(33656002)(4326008)(6506007)(74316002)(3280700002)(229853002)(110136005)(478600001)(6436002)(54906003)(53936002)(9686003)(59450400001)(74482002)(14454004)(102836004)(55016002)(5250100002)(2906002)(6246003)(8936002)(39060400002); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1073; H:YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: jfG+RyR6/D5MfqYCnUmmUYBFK2Q/UgmFGUZWErcvl55yTPXxj+tEn+5kydd+opMGjftCCBigaZnek/rY3pQhhe8YiboEuxTqqzVp+ob1+0E1c5DKc+QLhfxP4aQF27DXEXGVQUrTlXHTkA6LY0eLmsozvGaFezV0HwDMghRGtZLQe+OWvin7yp3U3O0NMjok spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e284a8a6-99c9-40a2-dfc4-08d5a3926615 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: e284a8a6-99c9-40a2-dfc4-08d5a3926615 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2018 12:05:51.5430 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1073 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 12:05:54 -0000 Julian Elischer wrote: >On 16/4/18 6:56 pm, Konstantin Belousov wrote: [stuff snipped] >>> + ngroups =3D XU_NGROUPS + 1; >> Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ? >valid question.. because that is how many are allocated? >it was a "minimally invasive patch".. whoever used XU_NGROUPS before >should have fixed it. >Having said that, thanks for drawing out attention to it.. will >probably fix. 16 is the limit specified in the RFCs for Sun RPC, so that is the "on the w= ire" limit. I haven't looked at the code. It might make sense to handle more here and t= hen set the limit at 16 after getting rid of duplicates, but I have no idea if = it matters? rick [more stuff snipped]