From owner-freebsd-hackers@freebsd.org Fri Mar 30 08:38:16 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAC12F50ABA for ; Fri, 30 Mar 2018 08:38:16 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from mail.ptrcrt.ch (ptrcrt.ch [IPv6:2a02:2770:8:0:21a:4aff:fe7e:c6be]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 284957D438 for ; Fri, 30 Mar 2018 08:38:16 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from mail.ptrcrt.ch (mail.ptrcrt.ch [192.168.1.1]) by mail.ptrcrt.ch (OpenSMTPD) with ESMTP id bf5b6617; Fri, 30 Mar 2018 08:38:13 +0000 (UTC) Received: from ptrcrt.ch (mail.ptrcrt.ch [192.168.1.1]) by mail.ptrcrt.ch (OpenSMTPD) with ESMTPS id e0a1daca TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Fri, 30 Mar 2018 08:38:13 +0000 (UTC) Date: Fri, 30 Mar 2018 08:38:13 +0000 From: Pietro Cerutti To: "Simon J. Gerraty" Cc: freebsd-hackers@FreeBSD.org Subject: Re: bmake: variable modifiers in SysV include Message-ID: <20180330083813.jfq3kwb5bzuhpeie@ptrcrt.ch> Reply-To: Pietro Cerutti References: <20180328115825.ydfnbly6hpsvbo3h@ptrcrt.ch> <4361.1522282416@kaos.jnpr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="enbehtemswptyf5c" Content-Disposition: inline In-Reply-To: <4361.1522282416@kaos.jnpr.net> X-PGP-Key: fp="DA6D E106 A5B8 54B8 5DD8 6D49 ADD0 D38E A192 089E"; id="0xA192089E"; get=; get=; get=; get= OpenPGP: id=A192089E; url=https://gahr.ch/pgp/0xADD0D38EA192089E.txt; url=https://keybase.io/gahr/key.asc User-Agent: NeoMutt/20180323-25-688f04 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 08:38:17 -0000 --enbehtemswptyf5c Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mar 28 18 17:13, Simon J. Gerraty wrote: >Pietro Cerutti wrote: > >> our make (contrib/bmake) does not currently support variable modifiers >> in SysV-style "include" directives. See this simple example: > >> Apart from parentheses reshuffling, the patch just removes a check >> that inhibits SysV inclusion if the line being parsed contains a colon >> (:) character. >> >> This has been there since bmake has supported SysV includes [2]. >> >> Questions: >> >> 1. Any ideas why the check is there, and what problem it's preventing? >> 2. Anybody with src bit would like to approve me committing the fix? > >Can you pls fwd your issue to tech-toolchain@netbsd.org (cc me) >that way whoever it was who added the support for sysV style include >can comment. Hi Simon, I can't reply to Christos' email properly because I'm not subscribed to=20 that ML. Anyway, it looks like the original reason for the check on the=20 colon doesn't look too sustainable anymore :) Would you like to commit my fix to NetBSD? Thanks! --=20 Pietro Cerutti --enbehtemswptyf5c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAlq993EuFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII no2zEACLLP+84VjrsHyIk1sboPew+aeP5YxS/S0aDLGxYR91kRf3p/NMDg+VolC/ iFTHyd34t8jP1OXysMTRDwI3SMbTrQLGJXSNBam6sbS4+xNFNZ2UBHVuQfDYkBUS 29suIbMZowZvon+biBwJf7gFKKI9hUqVMFmEMc1N97zTFrb4Msr1GgRZETaI945P bbc2cKfHw6TbzvhAoyNH8S2iaIUUngFQrxQSMS729k45PhW7/QWP4xtxKQwSh80d wGtEGyVqrHHs4PqE8KkKYNOtWRhIHUh4rb2LQc4NGkkxSPqEZuiiiD2I8kePQRjO 7eCQSGQhs9fG2e9c4Rtms6JWUQ8XDTrzNu7P4cH28TQBXgW2pAR1OV5Dbppf4PVz S/oUMpefW1RasQTykcL9BlFI97P0Z57in/ufgyWhMXxBmtQUCrAUfo06KDoNtu/i 9wChYWkdw0jtyoD7yAAhLOautA4yGKb29lJM+JWw+rWLew3WQ+KFpN/ZMxd524wI heBIrCmGjIb9eQOEt7WEDfdxVCUmj4vrakclCG/e7W6VpXtHUg2elWAwboYvjWBu H9ilk11AO/G1vsl1WXcxpMhSs4j4WzjVj044BOJ3hakdcGvi3RgSzHrbaE4hz42F 0eVRIgeP0PBWYGzKxMLEXz8GZwu4NsdDoqZjoDNbixuWK26gfA== =IX13 -----END PGP SIGNATURE----- --enbehtemswptyf5c--