From nobody Thu Jun 22 21:11:10 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QnCht5sc2z4gfFS; Thu, 22 Jun 2023 21:11:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QnCht4KwFz49Ch; Thu, 22 Jun 2023 21:11:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687468270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eykqSpyZ6y7oyJ7gNqyiwFi+rNO4KRnj0kQmrn9jL9A=; b=Vc/wrloYMZmRH7XVX/CxgiRnZSP/CVIBDqsku/LGG4M9nZXpnaLqRg7aLs/zKzBp9wp/A3 /LzWcVyrhNzh8my2d+qoadmkmgeSIhne8W0kRpYWpoaEMeDxnBU7Dt+hFhnIOG2xbp7PVt xSgEnAyxB2qZf3dFkucR8DCPlZw4/NjiVhP88eXIewH6JN61/M3QSAORq3DDXXlUdIX1CR e9oT1COlBJTcU2h8fdVF6g6bY7hkeNQT5cdGzfnzADA4+dWLPAtTpV8KYYDAOFV8mG7lfm KFl69dyxURHnPAsW3y21IoHZrkEVCWHP+MD8Vf86qo+kNp09yT17tAMQbYwuRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687468270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eykqSpyZ6y7oyJ7gNqyiwFi+rNO4KRnj0kQmrn9jL9A=; b=xrkOBPsKuJ6EsAbQw8IjSmDkI+RrYhuD9jWhI0C2R22/AAUgArCKD8tVe8U4VBY//PsbOU MlpdZsP15bEfOC0hb60N+O/ACoRchCFcdXEM30eWmaG7f1VMCy8y3JeV4XuHTcpA8XKn8+ mJg+e5Oed4YRmJGjeNuIM8Gp1MLEeg1IZn5b4Qbr9yeg1VFqbTERs97iNxGaZ6vvuoJCbA xJaHOt9QqQIPSCE/CQxtwBlWFiFyWoLHl/Bqhw2ANlH5Iy4lVg82oyshcXaHPFRmRESLac YHB/hBriFnGw3SzftNyWn/Ca6VRpW2jqXgY0gyujvrXGq2k/KSx9XIAc3yIhDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687468270; a=rsa-sha256; cv=none; b=nZSK7HdFnZga50nOQP1thIUkS8L2t20c7PjYSfScXBQ63QfwxFt8fqF5BENSBCzJR+PamS ShZIoHm0F4PHT5UsDHL/hjUOSRX/yoxDm0cJOVeQXSC2CHfKM1T/7ReQZvW5qfPfhuCS0l Lv0+hud8cTPSGPvTJ1GP1kohLDxE/MWxd2JuCyAV/UuWRKt44wfmI+6bdEiWvUC6gpfasC Hff4l7UbuXgA/g3+QtZF3Wp7gIazPb/QMbzEHI3/M001ksGCqUZz1g9vcMZqBqiVFafXoI cXtiRh0fSZsKKejGDo9Ub0QnlAqQVicmr3dHXzpfSn7C/+puc2zPBVkkAME5kw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QnCht2bqRzf5Q; Thu, 22 Jun 2023 21:11:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 35MLBAY1066212; Thu, 22 Jun 2023 21:11:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 35MLBAqB066211; Thu, 22 Jun 2023 21:11:10 GMT (envelope-from git) Date: Thu, 22 Jun 2023 21:11:10 GMT Message-Id: <202306222111.35MLBAqB066211@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: c3450ad127e9 - main - clang: re-downgrade implicit int/function declarations to warning only List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c3450ad127e94d3fa67ae337310e59c002f51bfc Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=c3450ad127e94d3fa67ae337310e59c002f51bfc commit c3450ad127e94d3fa67ae337310e59c002f51bfc Author: Dimitry Andric AuthorDate: 2023-04-25 19:24:04 +0000 Commit: Dimitry Andric CommitDate: 2023-06-22 18:22:33 +0000 clang: re-downgrade implicit int/function declarations to warning only This reapplies upstream commit c0141f3c300f by Aaron Ballman: Downgrade implicit int and implicit function declaration to warning only The changes in Clang 15.0.0 which enabled these diagnostics as a warning which defaulted to an error caused disruption for people working on distributions such as Gentoo. There was an explicit request to downgrade these to be warning-only in Clang 15.0.1 with the expectation that Clang 16 will default the diagnostics to an error. See https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213 for more details on the discussion. See https://reviews.llvm.org/D133800 for the public review of these changes. As noted in the upstream discussion, there are many programs that fail to configure or build correctly, if these warnings are turned into errors by default. Note that most affected programs in ports are relatively old, and are unlikely to be fixed by actually adjusting their declarations, but by compiling with -std=gnu89, which downgrades the errors back to warning again. Lots of tedious work for very little gain. --- .../llvm-project/clang/include/clang/Basic/DiagnosticSemaKinds.td | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/llvm-project/clang/include/clang/Basic/DiagnosticSemaKinds.td b/contrib/llvm-project/clang/include/clang/Basic/DiagnosticSemaKinds.td index bfe582d8252f..31a27558bca4 100644 --- a/contrib/llvm-project/clang/include/clang/Basic/DiagnosticSemaKinds.td +++ b/contrib/llvm-project/clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -419,7 +419,7 @@ def warn_implicit_function_decl : Warning< InGroup, DefaultIgnore; def ext_implicit_function_decl_c99 : ExtWarn< "call to undeclared function %0; ISO C99 and later do not support implicit " - "function declarations">, InGroup, DefaultError; + "function declarations">, InGroup; def note_function_suggestion : Note<"did you mean %0?">; def err_ellipsis_first_param : Error< @@ -709,7 +709,7 @@ def ext_implicit_lib_function_decl : ExtWarn< def ext_implicit_lib_function_decl_c99 : ExtWarn< "call to undeclared library function '%0' with type %1; ISO C99 and later " "do not support implicit function declarations">, - InGroup, DefaultError; + InGroup; def note_include_header_or_declare : Note< "include the header <%0> or explicitly provide a declaration for '%1'">; def note_previous_builtin_declaration : Note<"%0 is a builtin with type %1">; @@ -4390,7 +4390,7 @@ def err_ident_list_in_fn_declaration : Error< "a parameter list without types is only allowed in a function definition">; def ext_param_not_declared : ExtWarn< "parameter %0 was not declared, defaults to 'int'; ISO C99 and later do not " - "support implicit int">, InGroup, DefaultError; + "support implicit int">, InGroup; def err_param_default_argument : Error< "C does not support default arguments">; def err_param_default_argument_redefinition : Error< @@ -10104,7 +10104,7 @@ def warn_receiver_forward_class : Warning< def note_method_sent_forward_class : Note<"method %0 is used for the forward class">; def ext_missing_type_specifier : ExtWarn< "type specifier missing, defaults to 'int'; ISO C99 and later do not support " - "implicit int">, InGroup, DefaultError; + "implicit int">, InGroup; def err_missing_type_specifier : Error< "a type specifier is required for all declarations">; def err_decimal_unsupported : Error<