From owner-svn-ports-all@freebsd.org  Wed Dec 18 10:11:41 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id AF3871DA8DD;
 Wed, 18 Dec 2019 10:11:41 +0000 (UTC) (envelope-from lars@e.0x20.net)
Received: from mail.0x20.net (mail.0x20.net [46.251.251.56])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 47d9ld478xz4QBc;
 Wed, 18 Dec 2019 10:11:40 +0000 (UTC) (envelope-from lars@e.0x20.net)
Received: from e.0x20.net (mail.0x20.net [46.251.251.56])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (3096 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.0x20.net (Postfix) with ESMTPS id 91B99B0D3E;
 Wed, 18 Dec 2019 11:11:38 +0100 (CET)
Received: (from lars@localhost)
 by e.0x20.net (8.15.2/8.15.2/Submit) id xBIABc8Y005498;
 Wed, 18 Dec 2019 11:11:38 +0100 (CET) (envelope-from lars)
Date: Wed, 18 Dec 2019 11:11:38 +0100
From: Lars Engels <lars.engels@0x20.net>
To: Mathieu Arnold <mat@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r520331 - in head/net-mgmt: icingaweb2
 icingaweb2-module-businessprocess icingaweb2-module-cube
 icingaweb2-module-director icingaweb2-module-elasticsearch
 icingaweb2-module-fileshipper ...
Message-ID: <20191218101138.GC41599@e.0x20.net>
References: <201912171343.xBHDhEk9070377@repo.freebsd.org>
 <20191217142156.lkgunsqss4onibwp@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191217142156.lkgunsqss4onibwp@atuin.in.mat.cc>
X-Editor: VIM - Vi IMproved 8.0
User-Agent: Mutt/1.12.2 (2019-09-21)
X-Rspamd-Queue-Id: 47d9ld478xz4QBc
X-Spamd-Bar: -----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-6.00 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-0.999,0]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Dec 2019 10:11:41 -0000

On Tue, Dec 17, 2019 at 03:21:56PM +0100, Mathieu Arnold wrote:
> On Tue, Dec 17, 2019 at 01:43:14PM +0000, Lars Engels wrote:
> > +PKGNAMESUFFIX=	${PHP_PKGNAMESUFFIX}
> >  
> > +RUN_DEPENDS=	icingaweb2-${PHP_FLAVOR}>=2.4.1:net-mgmt/icingaweb2@${PHP_FLAVOR} \
> > +		icingaweb2-module-ipl-${PHP_FLAVOR}>=0.1.1:net-mgmt/icingaweb2-module-ipl@${PHP_FLAVOR}
> 
> This, and all the other are abusing the fact that PHP_FLAVOR is
> contained in PHP_PKGNAMESUFFIX.  The package names in all dependencies
> should be defined with PHP_PKGNAMESUFFIX, NOT PHP_FLAVOR.  For example:
> 
>   icingaweb2${PHP_PKGNAMESUFFIX}>=2.4.1::net-mgmt/icingaweb2@${PHP_FLAVOR}

Thanks! Fluffy@ updated the PR with your suggestion and I committed it.