From nobody Wed Jun 18 14:13:30 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bMm1X0x4xz5pflq; Wed, 18 Jun 2025 14:13:36 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bMm1W3n1hz3F65; Wed, 18 Jun 2025 14:13:35 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=S2KlkjUR; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::f32 as permitted sender) smtp.mailfrom=markjdb@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none) Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-6fae04a3795so73620066d6.3; Wed, 18 Jun 2025 07:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750256013; x=1750860813; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=PstYl2gtV/1OqNrAC0ZS2A7y7ZU+v3GZ0l1HOuWTWiw=; b=S2KlkjURNmsG+aZA4dWR1aKV5yEzqOED56oGc5+4sOXZw0/KUeRxMb9LrH0HBLBrzs sbiXYH9rjX7Rn4IWnzkDnLBIykaQGwJdsZkAALvWf8AdAKQZ1f4KbGToKzsneGEAP+BE IKqm1Q/+bshvmiu39Efu+uJrbOId78LcnML/qZsnV9LwDUFn94i9M4M2+lZ8NKgnbNtW 1dgSHpdnf7MXlDEd8z/ruzLa/j7ZaqOEH1aQQKUEwccCbsO5CSSWxnGNyDU74Od0oRjV R7wODS4MLlJsafBx2U+eYFE3nb8feqPYgX1ZX2YTDj/qLba8GVh3QL/t3IYCTIldZjHg W+iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750256013; x=1750860813; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PstYl2gtV/1OqNrAC0ZS2A7y7ZU+v3GZ0l1HOuWTWiw=; b=KisJzrkGeAunqEAcg1juMtj7/bbcH2X+ypxSrWkyO0Rif7p4qHdmXZvEJLLgcvIIIX FNzm1TaNfG7+VXv5cyfSzjbNohu1qN/VLs6dZ8Rn2HCyGW8ruO/r3jw4bOwve3DauJ3X iDN3/B71jjXxFGnBA1Ih/neb8K/+Itv0bCYH/5P0/1G2kL42UdFrD3JPnMmxpf7VFZSE Wuv6TvOu2Cu8wiXzbk89LdyJLXIJZCMxANoLoRaefPMyu5lB4Sa+z6XNOZ6GkvuPGRd4 CTqBaX5z3LkUt550PocKbOJ49DQw3AWn6izWoAWsQtFf4+gMmLrEENs0RMZNK4Y8WWxd KVbg== X-Forwarded-Encrypted: i=1; AJvYcCX414UfTQA7hvSMAFwJlVfj8d3AGNStml0o8Z/gTkkeO6PeqiLB6CrjcyKj62u5/E4xnPEBlOAkKo00BJDgEgNfy8/n@freebsd.org, AJvYcCXrcITcU4uY+/QqofCD/OXdK1yNMOJEIDaKEt+5sGcqhHPue7S3FFFZQwM9UBbvoXqmgUUfaZlCZCRymTOl/pd591EFOKQ=@freebsd.org X-Gm-Message-State: AOJu0Ywk7wxLMMFztTf9yknTCmBANbFP9SMDx6PpGTOjeH+dey4BWuoj J8rE93NqvYUg5wQzLro4wcNPxbgdS/Afsw6OHehvs4HZ3xEx80LK2c3L3dDcPhaj X-Gm-Gg: ASbGncsaaebxETFa2WJFUta4V2Std0+FpAmV2vMw4yDoJ8Vkwnrdjv1sycorQLvYzCm L5Uf6Vq1ahoICZq6msEqLwN2UJPemAdXZYQI3LzabkAfRonwkTf6/qU4DYs7EMtXz34sf4+XiTX NfOkrHE9SSPb2Epy/Kx94SmOcbCBPqPgfHSMZymFcoI0ui5CtF+M1MCT4G698KTqYvnl+46hLxf 5n31dGT5DumbZFwHr1YL38bhKnvl73JW2oTF8H3blakGXo1sxBaBMCrspBiFDTuim9dWeigHwii WIGJngjwzyL2mN0ZFn/G/RYweWjMcb5ay6g1v4zzmaRslJomSWtD13I0qy1UujMu9UjJRSFzIwy i X-Google-Smtp-Source: AGHT+IGmNxvZK036D73onKuYsytTeaMBPv5KQ9ZJIYuXZCg4lp1dpTt4sL0rIezh0LuSqv0xzcFCdw== X-Received: by 2002:a05:6214:434a:b0:6fa:fb4f:b58e with SMTP id 6a1803df08f44-6fb47626dc1mr256283326d6.6.1750256013321; Wed, 18 Jun 2025 07:13:33 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35c4acb3sm73359386d6.86.2025.06.18.07.13.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 07:13:32 -0700 (PDT) Date: Wed, 18 Jun 2025 10:13:30 -0400 From: Mark Johnston To: Hiroki Sato Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4deb9760a9d8 - main - rc: Disable pathname expansion when calling run_rc_command() Message-ID: References: <202506121820.55CIKQTQ097365@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202506121820.55CIKQTQ097365@gitrepo.freebsd.org> X-Spamd-Result: default: False [0.35 / 15.00]; NEURAL_SPAM_SHORT(1.00)[0.999]; NEURAL_HAM_MEDIUM(-0.62)[-0.623]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_LONG(-0.43)[-0.431]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f32:from]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCPT_COUNT_THREE(0.00)[4]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4bMm1W3n1hz3F65 X-Spamd-Bar: / On Thu, Jun 12, 2025 at 06:20:26PM +0000, Hiroki Sato wrote: > The branch main has been updated by hrs: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4deb9760a9d84d5861ee45162ffebe83f13503b8 > > commit 4deb9760a9d84d5861ee45162ffebe83f13503b8 > Author: Hiroki Sato > AuthorDate: 2025-06-12 18:19:32 +0000 > Commit: Hiroki Sato > CommitDate: 2025-06-12 18:19:32 +0000 > > rc: Disable pathname expansion when calling run_rc_command() > > Variables for command-line options like $foo_flags can contain characters > that perform pathname expansions, such as '[', ']', and '*'. They were > passed without escaping, and the matched entries in the working directory > affected the command-line options. This change turns off the expansion > when run_rc_command() is called. > > While this changes the current behavior, an invocation of a service > program should not depend on entries in the working directory. This also turns off globbing for /etc/rc.local, which broke one of my scripts. Was that intentional? If so, we should really document it in RELNOTES at the very least. > Differential Revision: https://reviews.freebsd.org/D45855 > --- > libexec/rc/rc.subr | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libexec/rc/rc.subr b/libexec/rc/rc.subr > index 2eaf336b5220..359eebd1d342 100644 > --- a/libexec/rc/rc.subr > +++ b/libexec/rc/rc.subr > @@ -1788,7 +1788,11 @@ _run_rc_doit() > debug "run_rc_command: doit: $*" > _m=$(umask) > ${_umask:+umask ${_umask}} > + > + # Disable pathname expansion temporarily for run_rc_command. > + set -o noglob > eval "$@" > + set +o noglob > _return=$? > umask ${_m} > >