From owner-cvs-all Sat Jul 21 5: 8: 6 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 7E7C837B406; Sat, 21 Jul 2001 05:07:58 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.4/8.11.4) with ESMTP id f6LC7uL09043; Sat, 21 Jul 2001 13:07:56 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.4/8.11.4) with ESMTP id f6LC7ug71082; Sat, 21 Jul 2001 13:07:56 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200107211207.f6LC7ug71082@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Hellmuth Michaelis Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/share/examples/isdn/i4brunppp i4brunppp.c In-Reply-To: Message from Hellmuth Michaelis of "Sat, 21 Jul 2001 04:52:31 PDT." <200107211152.f6LBqWN70603@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 21 Jul 2001 13:07:56 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > hm 2001/07/21 04:52:31 PDT > > Modified files: > share/examples/isdn/i4brunppp i4brunppp.c > Log: > Add a patch from the isdn mailinglist, Juha writes: > > ppp in 4.x apparently does a close(2) after opening the tun device; > i4brunppp starts up with only file descriptors 0 and 1 open (to the rbch > device) -> tun gets opened as 2 -> tun gets closed -> later use results > in EBADF. A quick fix to i4brunppp.c makes the thing work (I know, this > is ugly, but I needed it up quick...): > > Submitted by: Juha-Matti Liukkonen > > Revision Changes Path > 1.2 +2 -1 src/share/examples/isdn/i4brunppp/i4brunppp.c This bug has already been fixed and merged into -stable: ---------------------------- revision 1.167.2.7 date: 2001/07/10 21:19:38; author: brian; state: Exp; lines: +19 -2 MFC: Handle descriptors 0, 1 or 2 being closed when ppp is envoked ---------------------------- This i4brunppp.c fix should probably be backed out. BTW, do you know that sh(1) now supports <> properly ? This program could probably be converted to a script ending with exec ppp -direct $ppplabel <> /dev/i4brbch$unit -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message