From owner-svn-src-head@FreeBSD.ORG  Mon Jan 19 08:17:32 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 870BA106564A;
	Mon, 19 Jan 2009 08:17:32 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from sippysoft.com (gk1.360sip.com [72.236.70.240])
	by mx1.freebsd.org (Postfix) with ESMTP id 4F7F58FC0A;
	Mon, 19 Jan 2009 08:17:32 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from [192.168.1.38] (S0106001372fd1e07.vs.shawcable.net
	[70.71.171.106]) (authenticated bits=0)
	by sippysoft.com (8.13.8/8.13.8) with ESMTP id n0J8HUsv086706
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 19 Jan 2009 00:17:31 -0800 (PST)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <49743712.7030103@FreeBSD.org>
Date: Mon, 19 Jan 2009 00:17:22 -0800
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Sippy Software, Inc.
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: Scott Long <scottl@samsco.org>
References: <200901190710.n0J7ACSg001385@svn.freebsd.org>
	<497432A1.9060805@samsco.org>
In-Reply-To: <497432A1.9060805@samsco.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r187426 - head/sys/amd64/conf
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jan 2009 08:17:33 -0000

Scott Long wrote:
> Maxim Sobolev wrote:
>> Author: sobomax
>> Date: Mon Jan 19 07:10:11 2009
>> New Revision: 187426
>> URL: http://svn.freebsd.org/changeset/base/187426
>>
>> Log:
>>   Add asr(4) and stge(4) from i386 GENERIC. Both drivers compile on 
>> amd64 and
>>   there is no particular reason for them to be i386-only.
> 
> Yes, there is a particular reason why asr is i386 only.  This has been
> discussed extensively over the years, but to sum it up, no it is not
> 64-bit clean.  Please remove.
> 
> At this point in the lifecycle of amd64, you can be 100% assured that
> the list of compatible devices has been checked and rechecked a few
> dozen times.  You are not going to find hidden gems that people have
> forgotten about.  If you think you've found something, ask first, and
> prepare to be wrong.  And above all else, don't put drivers into here
> that you haven't tested.  It's pretty silly to admit in your commit
> message, for all to see, that you are blatantly committing without
> testing.

Point taken, thanks. Is there any technical reason why stge(4) not in there?

-Maxim