From nobody Wed Feb 1 17:17:56 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P6TBz3v1fz3bGNW; Wed, 1 Feb 2023 17:18:03 +0000 (UTC) (envelope-from weh@microsoft.com) Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2129.outbound.protection.outlook.com [40.107.255.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P6TBy6SkSz3MhL; Wed, 1 Feb 2023 17:18:02 +0000 (UTC) (envelope-from weh@microsoft.com) Authentication-Results: mx1.freebsd.org; none ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W5NriNcZE45+0Z7h86karspbQoii4LQFLD28E3ydhWcPAGSoTkoLpqDwp+p7yLK7/TH60nOBqr8Xg+DC2Gn1vzCNakVDKE74accYvZ7rbEP+Qmmw7WYXc1igVv60i+PtIhcYkvkYhjIa13XTdYNWw74A6aQV3zAQS/Il3z5umu1Ljvegdmb6SEUFG955klIDWQwuhHmZtg6YxTPuiWiXr+9QKsFAHahTp2I2P8vJ5HEpwyn0038I2Oi5rvudzTZDawpLHu/gf+S8Zq+AoHM7EoTFqsCfu4O1oPrrm5m91FTDhVmEAz+4B77LAMt+A/1bHDw8NavGsEL8PfvW6Nnczg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TSylnbtwpD7KlKsy96DdeKXxwMIZZGTTDJHseIZAdhI=; b=AeuD+JHTrnZqKLYCOG60g/m+cOOBmYz4R45m5IWIGay4+95Mbxpu6BSafHCv78U+0CW1ahtTpoZXD9DXMisvzPYHUZNAT8IdTk4T/3Ak9Pwtx+DJxalC1y1TDG10qncdy0S7gJEEKWmTR4mHq4yb3rAffj9RdXdgQv8zprrKOdcR4NIDJPt3Pk0Wt7NB1M7iabn7v8ekh7HVykm2eOP1pTsRhJZq17wL95ERkEmUuueo1nnxnZtFTNYSWsF893XSfjw1Ap7LR4ZKwDjzumSytFzQc/xaA9o+nNsS4ihuLbUULrxY7ksoPSbyOv5cY4BuhorBhkOpPuGFDFbWJ2aPoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TSylnbtwpD7KlKsy96DdeKXxwMIZZGTTDJHseIZAdhI=; b=hyZfXsSywVgwO6LqFLTbHSD4f7qcqFGRTfdhNNEQTJc5Y9zPVxemJ2x+u9g0qovF+7rJdcyDs33cfjoNr3XTznSTePAEWCh0zwU8q11iFAryT4CPrIGLbxS5AQeVFLV9d1VniaJvSxb9PNCawuVUi5oXvOS0HzJ63o3ngZbTlwg= Received: from SI2P153MB0441.APCP153.PROD.OUTLOOK.COM (2603:1096:4:fc::7) by SI2P153MB0745.APCP153.PROD.OUTLOOK.COM (2603:1096:4:1fd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.5; Wed, 1 Feb 2023 17:17:57 +0000 Received: from SI2P153MB0441.APCP153.PROD.OUTLOOK.COM ([fe80::de4c:b059:b7d1:4edc]) by SI2P153MB0441.APCP153.PROD.OUTLOOK.COM ([fe80::de4c:b059:b7d1:4edc%3]) with mapi id 15.20.6086.006; Wed, 1 Feb 2023 17:17:56 +0000 From: Wei Hu To: Jessica Clarke , Wei Hu CC: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: RE: git: 6e5b082cab8d - main - arm64: Hyper-V: vPCI: Adding Hyper-V PCI protocol 1.4 Thread-Topic: git: 6e5b082cab8d - main - arm64: Hyper-V: vPCI: Adding Hyper-V PCI protocol 1.4 Thread-Index: AQHZNlagTN+oEbMEIUWWzzx0RNGcIK66SneAgAAK+dA= Date: Wed, 1 Feb 2023 17:17:56 +0000 Message-ID: References: <202302011601.311G1tQY026686@gitrepo.freebsd.org> <928C844E-EBB1-4AFF-968C-46D387E954BA@freebsd.org> In-Reply-To: <928C844E-EBB1-4AFF-968C-46D387E954BA@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=f97c38be-6c7c-40ef-97aa-4aa5b6b68095;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-02-01T17:17:27Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SI2P153MB0441:EE_|SI2P153MB0745:EE_ x-ms-office365-filtering-correlation-id: d2aee8f8-de43-4751-e506-08db047842e1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4YPLuXjmR6I+xFOE8dCVISO6ucyEeFW0bzsppQbm0HYSyeKUSsuTC4WMYiBRK41ItKQge3TVQHyXtOCIe4B+ddkuFSOdPsDGNCNe76aZaMJYWHzxPToaABWVKEG+3FP0NM13IuN7uCW1U2WpHEtn95S9tqf9j4j36jSy7TeTn7skb+5QrIGex9T3yIk++mR9W2j3sCJ3+Bxq2Xb+yz9kf+pG6dSScpl7aVdlA8zEWdiLImPWKtTJVcs4iKVotjcIJXzI/Hxa5blqXEtslEqmy+hriQVeN0E/FOEJfngN6hY0M7RZ4C9tj/2oAmK0hnB+mJk35mvEaZNqG1Fiv5Wdz7k9ChRe34shD7nUch7qFqQss+24MN0XIiBQ9eNGTpLwzp8uZqNdLhoBH24XSg75LiRFm+Q6IO8FSUe4zZzjJD+0LRPVaEEtnKclISexkFMqEYZP9WcLr+cw1lRXJglx3tSJmqW2rTHanEY07i4kEavEjW1Gkkz+KQ6Ro+t1aZBovpHzU/+tdVVYMmOpgdR7DX0JYbzlX5TQIp8kgIacbJNz8Foq6ckgulO+zgLBJU+1KqqqNJdWl0tEQc/GDIZqL1GQMTD47cZlqUF9+Y8ZYHasqgGz8s8t+uy4M7BHLQeGBoQLdQ38kM4VL52COc9F0NCod8HGXJdiUlUaDsKTu3W/fRO6/uLKqPUKKGTt3BCAcUfi0ohtyZmkMTPZmr4GH542BETF4oxgidWPm779CR9WAdpmLafY+kZyHWB4mtNY x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2P153MB0441.APCP153.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(366004)(396003)(39860400002)(346002)(451199018)(186003)(8936002)(41300700001)(6506007)(9686003)(53546011)(83380400001)(38100700002)(122000001)(76116006)(450100002)(66946007)(64756008)(66556008)(86362001)(33656002)(4326008)(55016003)(5660300002)(52536014)(7696005)(66446008)(8676002)(71200400001)(966005)(478600001)(54906003)(110136005)(82960400001)(66476007)(82950400001)(38070700005)(316002)(8990500004)(2906002)(10290500003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?f61NB4wMXUFdwKHHs6IbRY1O6PsFlUg7+5OKMWK6HTEyuamXqRZ14GgNikWm?= =?us-ascii?Q?Y5DtgAEgvh6WU6YWvgDfkhnTHgaSCiYC6bts46g5vJZ7DF26SIor1+9FoiBb?= =?us-ascii?Q?Hgjm/Z+EgQu39s4m2/0VyGqMlUuuy3IsZe52Ma8T2wFe6U53SGPyVfXo5J4n?= =?us-ascii?Q?aVXFXYxxx5ZVrzj7Nvl8g1ou9PHoyBUyxm5BrvEffD5v8RxFk3ozQMXqQXQ7?= =?us-ascii?Q?ZYXNhBC3scDpfv+DqXvy/jYfvYLJRZWOjLrxLNqD8Jd3HbjmITVqWeQRdg5V?= =?us-ascii?Q?IGkblYJ4YkwV2FTTCy/9YiJKpUA/XrebP0mUdh0Ngflr3CpoiGsX+2kL4+wT?= =?us-ascii?Q?9nsTnpLZoGTt79NLyWVipDWKM6Re5bZhYVKnvpS7ZMnPFDW1M3k1R04dehsi?= =?us-ascii?Q?6TsIJSw6SnTRUIz6Bhjni5t+RB/d6GPRkzKPK/6xmJIEgVqK/4SHBR0xE0oc?= =?us-ascii?Q?LOY1E2z3DO3MTF2DQPqYFW+VqzJP6/peQkP5jSAyQOWVG8jdMadq+C99sYIq?= =?us-ascii?Q?bsiSZUK8cI48WLaDym0bgdTMl7IvxerHjuM+r0ozUw3uKQeFWWU/MUwYSjQX?= =?us-ascii?Q?hTmY4lQ8WUfnFfY98ajmaSBoa2Xs1c9bvJQfRFU2w2KvjfwsEkK1yXT6uRQj?= =?us-ascii?Q?E/VZJuUo9hP1fS98C+UP+/cDh38ULb0Y4UZxibj8g82nCb+cCjY/IN9FDqKQ?= =?us-ascii?Q?odWfA1WPxzPZqDuIm8yf1VEb6mtd/+yKujXJovijMY33RsCg+M/9sya7Ug+D?= =?us-ascii?Q?xbWzZs1paujW3vNal4w4JE4aPcmIscNomNQAp/6LpTwSx9zIzw/+OHuiI/Dm?= =?us-ascii?Q?k6f1La3STRz2VCQdp5D+9pumKJnKkrLaTXXWS5V5A6bHGBmUaNALEkuScwZT?= =?us-ascii?Q?ZxZlP7dWfFhe7oP2WXBRX8gn/0uH6W8jmMMT60mYtDzSnTbDXtTqWRKRjdfb?= =?us-ascii?Q?5R9D0qcV98Gg98Rjzm21+J4UUiFSybT2xTteTvYqrQY0pofi4bCTpaxoszIi?= =?us-ascii?Q?2BtCtVi+Q4/a6LztWw4wTvsyq6yJO4QIAZEN8LkVeZIUjlmV9h3No+/nfE7i?= =?us-ascii?Q?UBJjag8dymYZ3w8ToqukfPH800iGRq0X8NXwHX80qI2netEGFQGbdr9kRusn?= =?us-ascii?Q?mQGOrniBkCm3dyq/fyMfSWVHNhRAnXouKnRzOElzh4qNdmM9SUyf02rEPQta?= =?us-ascii?Q?5PuyJi09WHAnx0UX4w0v9/rbT9wKc7Mb6jTUKS3Sn0lnfU8uJeECsmgAl3Uo?= =?us-ascii?Q?MaxRZ+WI0DHFlE8pbUfxQb7533ScokDYgEfzMCaGatXdxfztvy6m3F+s0TG2?= =?us-ascii?Q?fKfS8XjDW9Y2tetkiSAknDlGBP4dlMVcl7C6QoK1Mgq6nHCh1jKsEi9+GUhX?= =?us-ascii?Q?KsPpOFwTLX6Fy/7qRbUxxGHjYAO8aWVE3r7Qa8lnkzjB5wAyLM8rBbEhq3T3?= =?us-ascii?Q?4j+Q4asPMwSLj/jPmVuoucOEYa7Caa3dvg5lq1ZnFzOF05NUThcuOrJJq58K?= =?us-ascii?Q?f5NITJotCcjx8NMPFB6s+TZtxzL77iX88QjWd+3ByXwQiybm0MLaKSORMcue?= =?us-ascii?Q?cCHUB6/lss2LEhc5zoYg2yU8q15Q0TmdIGSvSgzzLiJVQEJRbll8lpxHIkPc?= =?us-ascii?Q?qw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SI2P153MB0441.APCP153.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: d2aee8f8-de43-4751-e506-08db047842e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 17:17:56.7120 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bPOuHuBcO59sTHDEY/0AYb2xUKmLWfNwCl+rN0hNFrzmgRn2a23vKFmUHEOff4Zr6ZCTWvpr1w9/mecjSewibA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2P153MB0745 X-Rspamd-Queue-Id: 4P6TBy6SkSz3MhL X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Thanks. Will fix them in next commit. Wei > -----Original Message----- > From: Jessica Clarke > Sent: Thursday, February 2, 2023 12:38 AM > To: Wei Hu > Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org; dev- > commits-src-main@freebsd.org > Subject: Re: git: 6e5b082cab8d - main - arm64: Hyper-V: vPCI: Adding Hype= r- > V PCI protocol 1.4 >=20 > On 1 Feb 2023, at 16:01, Wei Hu wrote: > > > > The branch main has been updated by whu: > > > > URL: > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fcgit > > .freebsd.org%2Fsrc%2Fcommit%2F%3Fid%3D6e5b082cab8d9dd0eb0bce65c > f8cf268 > > > f11c7a25&data=3D05%7C01%7Cweh%40microsoft.com%7C5e862bbad0c64aacf > dda08db > > > 0472b73a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6381086630 > 000855 > > > 14%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luM > zIiLCJBTiI > > > 6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DnZ7DxHuR7YTM% > 2BDn5ScYzqI > > rgAg0TCe%2BSlVTDISCpyPw%3D&reserved=3D0 > > > > commit 6e5b082cab8d9dd0eb0bce65cf8cf268f11c7a25 > > Author: Wei Hu > > AuthorDate: 2023-02-01 15:55:03 +0000 > > Commit: Wei Hu > > CommitDate: 2023-02-01 16:00:10 +0000 > > > > arm64: Hyper-V: vPCI: Adding Hyper-V PCI protocol 1.4 > > > > This is enabling the PCI protocol 1.4 and corresponding structures > > in order to support arm64 Hyper-V. > > > > This is the 2nd of the three patches to enable Hyper-V vPCI support > > in arm64. > > > > Reviewed by: whu > > Tested by: Souradeep Chakrabarti > > Obtained from: Souradeep Chakrabarti > > Sponsored by: Microsoft > > Differential Revision: > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Frevi > > > ews.freebsd.org%2FD37780&data=3D05%7C01%7Cweh%40microsoft.com%7C5 > e862bba > > > d0c64aacfdda08db0472b73a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7 > C0%7C > > > 638108663000085514%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM > DAiLCJQIjo > > > iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DX > FPmBJGt > > joHQkFE%2Bh0OxZ8GKruZwcR%2FSgWeREsFnxoc%3D&reserved=3D0 > > --- > > sys/dev/hyperv/pcib/vmbus_pcib.c | 83 > > ++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 80 insertions(+), 3 deletions(-) > > > > diff --git a/sys/dev/hyperv/pcib/vmbus_pcib.c > > b/sys/dev/hyperv/pcib/vmbus_pcib.c > > index 98e1320e4379..ca495dab9516 100644 > > --- a/sys/dev/hyperv/pcib/vmbus_pcib.c > > +++ b/sys/dev/hyperv/pcib/vmbus_pcib.c > > @@ -28,6 +28,7 @@ > > __FBSDID("$FreeBSD$"); > > > > #ifdef NEW_PCIB > > +#include "opt_acpi.h" > > > > #include > > #include > > @@ -50,6 +51,9 @@ __FBSDID("$FreeBSD$"); #include > > #include > > > > +#if defined(__aarch64__) > > +#include > > +#endif > > #include > > #include > > #include > > @@ -62,10 +66,16 @@ __FBSDID("$FreeBSD$"); #include > > #include #include > > "pcib_if.h" > > - > > +#if defined(__i386__) || defined(__amd64__) > > #include > > #include > > - > > +#endif > > +#if defined(__aarch64__) > > +#include > > +#include > > +#include > > +#include > > +#endif > > #include #include > > > > #include @@ -142,7 +152,7 @@ > > wait_for_completion_timeout(struct completion *c, int timeout) > > return (ret); > > } > > > > -#define PCI_MAKE_VERSION(major, minor) ((uint32_t)(((major) << 16) | > > (major))) > > +#define PCI_MAKE_VERSION(major, minor) ((uint32_t)(((major) << 16) | > > +(minor))) > > > > enum { > > PCI_PROTOCOL_VERSION_1_1 =3D PCI_MAKE_VERSION(1, 1), @@ - > 182,6 +192,12 > > @@ enum pci_message_type { > > PCI_QUERY_PROTOCOL_VERSION =3D PCI_MESSAGE_BASE + 0x13, > > PCI_CREATE_INTERRUPT_MESSAGE =3D PCI_MESSAGE_BASE + 0x14, > > PCI_DELETE_INTERRUPT_MESSAGE =3D PCI_MESSAGE_BASE + 0x15, > > + PCI_RESOURCES_ASSIGNED2 =3D PCI_MESSAGE_BASE + 0x16, > > + PCI_CREATE_INTERRUPT_MESSAGE2 =3D PCI_MESSAGE_BASE + 0x17, > > + PCI_DELETE_INTERRUPT_MESSAGE2 =3D PCI_MESSAGE_BASE + 0x18, > /* unused */ > > + PCI_BUS_RELATIONS2 =3D PCI_MESSAGE_BASE + 0x19, > > + PCI_RESOURCES_ASSIGNED3 =3D PCI_MESSAGE_BASE + 0x1A, > > + PCI_CREATE_INTERRUPT_MESSAGE3 =3D PCI_MESSAGE_BASE + 0x1B, > > PCI_MESSAGE_MAXIMUM > > }; > > > > @@ -223,6 +239,22 @@ struct pci_func_desc { > > uint32_t ser; /* serial number */ > > } __packed; > > > > +struct pci_func_desc2 { > > + uint16_t v_id; /* vendor ID */ > > + uint16_t d_id; /* device ID */ > > + uint8_t rev; > > + uint8_t prog_intf; > > + uint8_t subclass; > > + uint8_t base_class; > > + uint32_t subsystem_id; > > + union win_slot_encoding wslot; > > + uint32_t ser; /* serial number */ > > + uint32_t flags; > > + uint16_t virtual_numa_node; > > + uint16_t reserved; > > +} __packed; > > + > > + > > struct hv_msi_desc { > > uint8_t vector; > > uint8_t delivery_mode; > > @@ -231,6 +263,15 @@ struct hv_msi_desc { > > uint64_t cpu_mask; > > } __packed; > > > > +struct hv_msi_desc3 { > > + uint32_t vector; > > + uint8_t delivery_mode; > > + uint8_t reserved; > > + uint16_t vector_count; > > + uint16_t processor_count; > > + uint16_t processor_array[32]; > > +} __packed; > > + > > struct tran_int_desc { > > uint16_t reserved; > > uint16_t vector_count; > > @@ -288,6 +329,12 @@ struct pci_bus_relations { > > struct pci_func_desc func[0]; > > } __packed; > > > > +struct pci_bus_relations2 { > > + struct pci_incoming_message incoming; > > + uint32_t device_count; > > + struct pci_func_desc2 func[0]; > > +} __packed; > > + > > #define MAX_NUM_BARS (PCIR_MAX_BAR_0 + 1) > > struct pci_q_res_req_response { > > struct vmbus_chanpkt_hdr hdr; > > @@ -303,12 +350,26 @@ struct pci_resources_assigned { > > uint32_t reserved[4]; > > } __packed; > > > > +struct pci_resources_assigned2 { > > + struct pci_message message_type; > > + union win_slot_encoding wslot; > > + uint8_t memory_range[0x14][6]; /* not used here */ > > + uint32_t msi_descriptor_count; > > + uint8_t reserved[70]; > > +} __packed; > > + > > struct pci_create_interrupt { > > struct pci_message message_type; > > union win_slot_encoding wslot; > > struct hv_msi_desc int_desc; > > } __packed; > > > > +struct pci_create_interrupt3 { > > + struct pci_message message_type; > > + union win_slot_encoding wslot; > > + struct hv_msi_desc3 int_desc; > > +} __packed; > > + > > struct pci_create_int_response { > > struct pci_response response; > > uint32_t reserved; > > @@ -356,12 +417,28 @@ struct hv_pcibus { > > > > struct mtx config_lock; /* Avoid two threads writing index page */ > > struct mtx device_list_lock; /* Protect lists below */ > > + uint32_t protocol_version; > > TAILQ_HEAD(, hv_pci_dev) children; > > TAILQ_HEAD(, hv_dr_state) dr_list; > > > > volatile int detaching; > > }; > > > > +struct hv_pcidev_desc { > > + uint16_t v_id; /* vendor ID */ > > + uint16_t d_id; /* device ID */ > > + uint8_t rev; > > + uint8_t prog_intf; > > + uint8_t subclass; > > + uint8_t base_class; > > + uint32_t subsystem_id; > > + union win_slot_encoding wslot; > > + uint32_t ser; /* serial number */ > > + uint32_t flags; > > + uint16_t virtual_numa_node; > > +} __packed; >=20 > The indentation for these structs is all over the place. >=20 > > + > > + >=20 > Extra blank line. >=20 > Jess >=20 > > struct hv_pci_dev { > > TAILQ_ENTRY(hv_pci_dev) link; > >