Date: Wed, 02 May 2007 22:16:37 -0700 From: Tim Kientzle <kientzle@freebsd.org> To: Colin Percival <cperciva@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c Message-ID: <46397035.7000606@freebsd.org> In-Reply-To: <200705030433.l434XBvW005733@repoman.freebsd.org> References: <200705030433.l434XBvW005733@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Colin Percival wrote: > cperciva 2007-05-03 04:33:11 UTC > > FreeBSD src repository > > Modified files: > usr.bin/tar write.c > Log: > If lstat(2) fails, have bsdtar return a non-zero exit code if the > failed path is one which was specified on the command line. This looks like a nice compromise. I wonder if it would be simpler to set non-zero exit only if this is the first path returned from tree_next() (which should be the path given on the command line). That would avoid the headache of having to perform a textual path comparison. A simple flag to indicate if this is the first time through the loop should suffice, I think. Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46397035.7000606>