Date: Sat, 23 Mar 2013 00:28:47 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Gleb Kurtsou <gleb.kurtsou@gmail.com> Cc: arch@freebsd.org Subject: Re: Increase the mount path to MAXPATHLEN? Message-ID: <20130322222847.GY3794@kib.kiev.ua> In-Reply-To: <20130321034340.GA1120@reks> References: <20130319201145.GA19260@ambrisko.com> <20130320102116.GA3794@kib.kiev.ua> <20130321034340.GA1120@reks>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Mar 20, 2013 at 08:43:40PM -0700, Gleb Kurtsou wrote: > On (20/03/2013 12:21), Konstantin Belousov wrote: > > On Tue, Mar 19, 2013 at 01:11:45PM -0700, Doug Ambrisko wrote: > > > I have a patch at: > > > http://people.freebsd.org/~ambrisko/statf.patch > > > that people can glance at. If this approach is the right way to go > > > then I update it for the latest -current and update it. > > > > No, I do not think this is the right approach. > > You are breaking the ABI in the backward-incompatible way. > > > > What should be done is versioning the fstatfs(2) and other related > > symbols from libc. Please look at the lib/libc/include/compat.h > > and its use for upgrading the syscalls ABI. > > MNAMELEN switch to 1024 was implemented during GSoc 2011. > https://github.com/glk/freebsd-ino64/commit/f2b990cf8861bb72d4477b39426cbe33f95ffcdf > > freebsd-ino64 repo should contain most recent code, I'll double check > during weekend. It also contains patch to change dev_t to 64 bit. > > https://github.com/glk/freebsd-ino64/commits/projects/ino64 > > Konstantin, do you think it's worth pushing ino64 into CURRENT > considering 10.0 is approaching? The only unresolved issue I can recall > is ABI breakage in audit syscalls, providing compat shims for them > wasn't straightforward due to complex structure. Yes, I do think that ino_t should be finally fixed. Also, please do commit the ABI checking tool to svn. > > Unfortunately I've been swamped at $JOB for a while now and had no time > to clean it up and commit. So if somebody is willing to help please > contact me. What do you need ? What is the estimated time for making this done ? > > > Also, the whole ABI of the system should be inspected for the changes, > > due to possible use of the struct statfs in other structures, or as > > an argument to other functions. > > > > Gleb Kurtsou (gleb@) has a tool which could compare a set of the shlibs > > before and after change for the ABI drift, using the dward debugging > > information. I do not remember where it is stored, definitely worth > > committing somewhere at tools/tools. > > https://github.com/glk/shlib-compat > [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRTNsfAAoJEJDCuSvBvK1BHkYQAKXvOOjR4O1U5Sz79ot2Ntfs /x7e6HzepTn2XKnGieOw1jtX74jw6PtoswvP0eXCAPRtBZVOCngDoLeOiK4dr4QV SBFIuUxyvNmx8ChrL/AhI3XUqvNOv01VQ5r6axZoDQMPWQbbSPO5NidV7DScsa4m nHs+ZBndUEuUIeImCR25hIKNIecbD5kWLJawMOArdRF2j/Iq8LbwLPu/nVAqURoE +8A1jcZaLJ4lJLLgOu1h2wlUJPhY/Dds0Q2xBvip+20MezIBjmRXtrS4DSvOXSu0 14RhXQ3zxRC8IBW//+gjchviITbC4YRzh3ICO/rbiZqbzalqHBc5yRbNztJ+IlRh VYFe7BbOGwlweEp1JGTnrjPkOblagGPwR3NySlCduDJMzsjwHiswJ9wn1XH4Vi+6 ZiBANKz2b/XxQs/7ezchaQ46dorInif9IcV8iKNK0HYxG8nFE5KRFUXVkT1EcBls kGepg6Ygz+0imtN2UxPUpuDqqzvu3a41yaDVE7spKsBTbg5kV2oHAfF76B/wieYw bCfjuAPG44GeswceCVeBYXTPtsMgyDqxUabXH39gzGtSOIFUWwoAwppR2QPnFHzq qjGRvTnZJ9flfRN/utzSQaryQa95FXAz0KcAlF745PkdLobL47KGtE0RXCUkW6Ax zc6DU8/spK+S1lwq+sUx =bm8H -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130322222847.GY3794>