From owner-freebsd-ports-bugs@freebsd.org Thu Aug 10 20:18:18 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 47D5ADDC103 for ; Thu, 10 Aug 2017 20:18:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 350916FFD2 for ; Thu, 10 Aug 2017 20:18:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7AKIH8O089628 for ; Thu, 10 Aug 2017 20:18:18 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 221397] ports-mgmt/portlint: Shouldn't suggest to use $(VARIABLE) in replacement clauses Date: Thu, 10 Aug 2017 20:18:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: yuri@rawbw.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: marcus@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2017 20:18:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221397 Bug ID: 221397 Summary: ports-mgmt/portlint: Shouldn't suggest to use $(VARIABLE) in replacement clauses Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: yuri@rawbw.com Assignee: marcus@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) Created attachment 185241 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185241&action= =3Dedit Makefile (testcase) This statement > @${REINPLACE_CMD} -e ' \ > s|ExtraCompiler.commands =3D $$$${QMAKE_CXX} -fPIC|ExtraC= ompiler.commands =3D $$$${QMAKE_CXX} $$(CXXFLAGS) -fPIC|g' \ > ${WRKSRC}/polyphone.pro makes 'portlint -A' print: > WARN: /usr/ports/audio/polyphone/pkg-plist: There are only 4 items in the= plist. Consider using PLIST_FILES instead of pkg-plist when installing le= ss than 6 items. > WARN: Makefile: [44]: use ${VARIABLE}, instead of $(VARIABLE). It shouldn't complain about a double-dollared varable $$(CXXFLAGS), because= it specifies a replacement string, not a Makefile string. Additionally, the line it complains is ${WRKSRC}/polyphone.pro, not the act= ual line. --=20 You are receiving this mail because: You are the assignee for the bug.=