From owner-freebsd-ports-bugs@freebsd.org Fri Aug 4 02:12:29 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF712DBEC2B for ; Fri, 4 Aug 2017 02:12:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B1D0974FA4 for ; Fri, 4 Aug 2017 02:12:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v742CRkY022849 for ; Fri, 4 Aug 2017 02:12:29 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 220978] mail/dcc-dccd: Mixes data and code, does not respect hier(7) Date: Fri, 04 Aug 2017 02:12:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ultima@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 02:12:29 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220978 --- Comment #4 from Richard Gallamore --- (In reply to Piotr Kubaj from comment #3) Keeping /usr/local/dcc is fine, /var/db/dcc should work as well. /var/dcc w= ont be acceptable however. I know this is the vendor's default for dcc-dccd, but this simply is not an acceptable location for any FreeBSD port to reside. I have a couple of questions about this patch, 1: DCCDATA knob seems more like a complete change of DCCHOME. Is this suppo= sed to be an option? It would probably be better to add an option simply changi= ng the DCCHOME var instead. For example, ALT_HOME_VAR=3D DCCHOME=3D/var/db/dcc ALT_HOME_VAR_OFF=3D DCCHOME=3D${PREFIX}/dcc * The pkg-message has %%DCCHOME%%/dcc_conf while this was changed in pkg-pl= ist. 3: I like this change, but I am worried about some of the scripts not worki= ng correctly. This will need to be verified. 4: Looks good 5: with the configure_arg, --without-DCC-MD5 this shouldn't be linked at all correct? removing it completely as you have should be fine. As for further improvements: Changing files/*.in should be as easy as adding %%DCCHOME%%/DCCHOME=3D to = the file/SUB_LIST. I don't think there really is a standard directory for cgi-bin. Don't know enough about the port to know if this is important enough to move. --=20 You are receiving this mail because: You are the assignee for the bug.=