From owner-p4-projects@FreeBSD.ORG  Fri Aug  4 16:01:50 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A472116A4E7; Fri,  4 Aug 2006 16:01:50 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8200D16A569;
	Fri,  4 Aug 2006 16:01:50 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DA00F43D46;
	Fri,  4 Aug 2006 16:01:49 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k74G1ikB004558;
	Fri, 4 Aug 2006 12:01:48 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Paolo Pisati <piso@freebsd.org>
Date: Fri, 4 Aug 2006 11:43:26 -0400
User-Agent: KMail/1.9.1
References: <200608041457.k74EvpSw097626@repoman.freebsd.org>
In-Reply-To: <200608041457.k74EvpSw097626@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200608041143.26838.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Fri, 04 Aug 2006 12:01:48 -0400 (EDT)
X-Virus-Scanned: ClamAV version 0.87.1,
	clamav-milter version 0.87 on server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 103173 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Aug 2006 16:01:50 -0000

On Friday 04 August 2006 10:57, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=103173
> 
> Change 103173 by piso@piso_newluxor on 2006/08/04 14:57:30
> 
> 	taskqueue_free() executes all the tasks still pending
> 	on that taskqueue: in this case, taskqueue_drain() is
> 	superfluous.
> 
> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/dev/bfe/if_bfe.c#6 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/dev/bfe/if_bfe.c#6 (text+ko) ====
> 
> @@ -475,8 +475,6 @@
>  		device_delete_child(dev, sc->bfe_miibus);
>  
>  	bfe_release_resources(sc);
> -	taskqueue_drain(sc->sc_tq, &sc->sc_stoptask);
> -	taskqueue_drain(sc->sc_tq, &sc->sc_errorstask);
>  	taskqueue_free(sc->sc_tq);
>  	BFE_UNLOCK(sc);
>  	mtx_destroy(&sc->bfe_mtx);

In that case you can't call it while holding the BFE_LOCK.  You probably only 
need the BFE_LOCK around bfe_stop().

-- 
John Baldwin