Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Jul 2017 14:34:01 +0000 (UTC)
From:      Roman Bogorodskiy <novel@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r445652 - in head/audio/id3lib: . files
Message-ID:  <201707131434.v6DEY1dE011174@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: novel
Date: Thu Jul 13 14:34:01 2017
New Revision: 445652
URL: https://svnweb.freebsd.org/changeset/ports/445652

Log:
  audio/id3lib: fix stack corruption bug
  
  Add a patch to fix stack corruption bug when reading IDv3 tags
  and VBR header information.
  
  PR:		220374
  Submitted by:	bob@eager.cx
  Obtained from:	https://sourceforge.net/p/id3lib/bugs/189/
  MFH:		2017Q3
  Approved by:	maintainer timeout

Added:
  head/audio/id3lib/files/patch-src_mp3__parse.cpp   (contents, props changed)
Modified:
  head/audio/id3lib/Makefile

Modified: head/audio/id3lib/Makefile
==============================================================================
--- head/audio/id3lib/Makefile	Thu Jul 13 13:58:42 2017	(r445651)
+++ head/audio/id3lib/Makefile	Thu Jul 13 14:34:01 2017	(r445652)
@@ -3,7 +3,7 @@
 
 PORTNAME=	id3lib
 PORTVERSION=	3.8.3
-PORTREVISION=	9
+PORTREVISION=	10
 CATEGORIES=	audio
 MASTER_SITES=	SF
 

Added: head/audio/id3lib/files/patch-src_mp3__parse.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/audio/id3lib/files/patch-src_mp3__parse.cpp	Thu Jul 13 14:34:01 2017	(r445652)
@@ -0,0 +1,11 @@
+--- src/mp3_parse.cpp.orig	2017-07-13 13:36:15 UTC
++++ src/mp3_parse.cpp
+@@ -465,7 +465,7 @@ bool Mp3Info::Parse(ID3_Reader& reader, size_t mp3size
+   // from http://www.xingtech.com/developer/mp3/
+ 
+   const size_t VBR_HEADER_MIN_SIZE = 8;     // "xing" + flags are fixed
+-  const size_t VBR_HEADER_MAX_SIZE = 116;   // frames, bytes, toc and scale are optional
++  const size_t VBR_HEADER_MAX_SIZE = 120;   // frames, bytes, toc and scale are optional
+ 
+   if (mp3size >= vbr_header_offest + VBR_HEADER_MIN_SIZE) 
+   {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201707131434.v6DEY1dE011174>