From owner-freebsd-questions Thu Mar 16 11:44:27 2000 Delivered-To: freebsd-questions@freebsd.org Received: from mojave.worldwide.lemis.com (dhcp152.cdrom.com [204.216.28.152]) by hub.freebsd.org (Postfix) with ESMTP id 7CFCE37C1EB for ; Thu, 16 Mar 2000 11:43:55 -0800 (PST) (envelope-from grog@mojave.worldwide.lemis.com) Received: (from grog@localhost) by mojave.worldwide.lemis.com (8.9.3/8.9.3) id MAA01949; Wed, 15 Mar 2000 12:09:40 -0800 (PST) (envelope-from grog) Date: Wed, 15 Mar 2000 12:09:40 -0800 From: Greg Lehey To: mackler-fb@dewline.com Cc: freebsd-questions@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/fsck fsck.h setup.c inode.c Message-ID: <20000315120940.F1613@mojave.worldwide.lemis.com> Reply-To: Greg Lehey References: <200003151617.LAA19778@barter.dewline.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <200003151617.LAA19778@barter.dewline.com>; from mackler-fb@dewline.com on Wed, Mar 15, 2000 at 11:17:55AM -0500 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-freebsd-questions@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG [Format recovered--see http://www.lemis.com/email/email-format.html] On Wednesday, 15 March 2000 at 11:17:55 -0500, mackler-fb@dewline.com wrote: >> Date: 02/29/2000 >> Author: Kirk McKusick >> >> mckusick 2000/02/28 12:02:42 PST >> >> Modified files: >> sbin/fsck fsck.h setup.c inode.c >> Log: >> Yesterday I had to fix a badly broken disk, and found that fsck kept dying: >> >> DIR I=64512 CONNECTED. PARENT WAS I=4032 >> fsck: cannot find inode 995904 >> >> fsdb found the inodes with no problem: >> >> fsdb (inum: 64512)> inode 995904 >> current inode: directory >> I=995904 MODE=40777 SIZE=512 >> MTIME=Feb 14 15:27:07 2000 [0 nsec] >> CTIME=Feb 14 15:27:07 2000 [0 nsec] >> ATIME=Feb 24 10:31:58 2000 [0 nsec] >> OWNER=nobody GRP=nobody LINKCNT=4 FLAGS=0 BLKCNT=2 GEN=38a41386 >> Direct blocks: 8094568 0 0 0 0 0 0 0 0 0 0 0 >> Indirect blocks: 0 0 0 >> >> The problem turns out to be a program logic error in fsck. It >> stores directory inodes internally in hash lists, using the >> number of directories to form the hash key: >> >> inpp = &inphead[inumber % numdirs]; >> >> Elsewhere, however, it increments numdirs when it finds >> unattached directories. I've made the following fix, which >> solved the problem in the case in hand. >> >> Submitted by: Greg Lehey >> Reviewed by: Matthew Dillon >> Approved by: Kirk McKusick > > I'm having the same problem mentioned in this message that I'm > quoting. When I use cvsup to update my sources (RELENG_3) I'm not > getting these updated sources for fsck. How can I do this? How did you manage to remove the line breaks in the original message? I'm planning to commit this Real Soon Now. Greg -- When replying to this message, please copy the original recipients. For more information, see http://www.lemis.com/questions.html Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-questions" in the body of the message