From owner-svn-src-head@freebsd.org Wed Feb 22 16:15:08 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF9E0CE99B5; Wed, 22 Feb 2017 16:15:08 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 60DCA13DC; Wed, 22 Feb 2017 16:15:08 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id v77so1248219wmv.0; Wed, 22 Feb 2017 08:15:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Rp0Da6sMjYj2CMMJ818dSgJspF1HcsktkUsyCKL1KfM=; b=di12ocborndq4g8zD0t7nUTxPOep9CA9E8/xSIsYw4RyVj3MOzsfFKfmbDtVwS89ai Dn42kk/fD3+Zu9YhcxblQ0asQq5C1LeKR0yBYARS/0MzQsQKDbE8rTQgxyUQvrjCTfAg RMgUa/TRvNiuLKYuHp/F22p+OEAt2rtPbie9ZeqX8rJi7ReUWOYMLuNL6dG/bI9D6Lct Ss2quAXknKjdWzm5mU2wq1UB+Zcrq9oCdbyzsSL9F6PCSBk4pkyMvtOngL+JU8reRe0H IN72dsHvTR9+iZnl/bf1JtioEgIjtYnoE1C2tx5WIoRnGwbmlRPv/ag8mKWWeddAy26R xT9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Rp0Da6sMjYj2CMMJ818dSgJspF1HcsktkUsyCKL1KfM=; b=uMoIvumLyWASyz+slycWxR0GHNko/RSlAfoW/xAJypb4IKL0QfysN04M3EjFRFGQjj Dx0Lk1ZVoP7lJMEwSvVRLT3mrO0Rj+EHzKO/J2OvH2BhH8eiusY+eH07xgmI9qTpEigo w7W2blR9pbMxAT9ZVuDP6mAvBep0VA/IbM9MCZ2EZdgZq482UXa4w2PuQILXj4QsdtGY DuBi7y/7TB3+M3ZtTL3fuUc+3u0l8Rj4P3qeD7XGiO/6ZR+OJ/C7LOKvQ+/0xwgBwEkD LN6UDx/I5SYzwz3/5t7v3UKv1HLbBEbxu5h7vrgtEifzU8ZZMloE6VPV/kR1iQDSUgcc XP8Q== X-Gm-Message-State: AMke39k8VTxzzQ7/Vu3ECqvrOTmY0itAKJmPInNzB/ftPKcrX07R46RBz0hJy4ln4YaxZlocMgIk4jVTn5uN0A== X-Received: by 10.28.54.35 with SMTP id d35mr2913822wma.105.1487780106917; Wed, 22 Feb 2017 08:15:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.128.135 with HTTP; Wed, 22 Feb 2017 08:15:06 -0800 (PST) In-Reply-To: <4ffe93f6-f08a-070c-918d-c0dad443aa1f@selasky.org> References: <201702211323.v1LDNrJw087417@repo.freebsd.org> <4ffe93f6-f08a-070c-918d-c0dad443aa1f@selasky.org> From: Adrian Chadd Date: Wed, 22 Feb 2017 08:15:06 -0800 Message-ID: Subject: Re: svn commit: r314043 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf modules/linuxkpi To: Hans Petter Selasky Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2017 16:15:08 -0000 Sweet! Thanks! (God I'd like this for native FreeBSD drivers actually...) -adrian On 22 February 2017 at 01:22, Hans Petter Selasky wrote: > On 02/22/17 00:18, Adrian Chadd wrote: >> >> Hiya, >> >> My understanding of tasklets is that they run on the CPU that they >> were scheduled on, rather than there being a single tasklet thread? >> >> Is that the direction you're thinking of heading in, or? >> > > Hi Adrian, > > The plan is to use grouptaskqueue in the end. From what I can see all the > pieces are in place for that. Then the tasklets will run on the same CPU > that they were scheduled on. > > Some patches needs to go into the grouptaskqueue first: > > 1) grouptaskqueue needs to support LinuxKPI module unload. There is current > missing/unimplemented drain logic in grouptaskqueue APIs. > > 2) Needs to expose internal gtaskqueues, so that we don't create unneccesary > threads to handle a single IRQ, which is the case currently. > > I've already CC'ed a few people on this, but not action yet. If you can > help, would be great. > > BTW: > TASKQGROUP_DECLARE(net); > > in sys/gtaskqueue.h seems non-existing and should be removed. > > --HPS >