From owner-freebsd-ports Thu Nov 2 23:59: 3 2000 Delivered-To: freebsd-ports@freebsd.org Received: from newmail.netbistro.com (newmail.netbistro.com [204.239.167.35]) by hub.freebsd.org (Postfix) with SMTP id 26DFB37B4CF for ; Thu, 2 Nov 2000 23:59:00 -0800 (PST) Received: (qmail 17967 invoked by uid 1020); 3 Nov 2000 07:58:59 -0000 Date: Thu, 2 Nov 2000 23:58:59 -0800 (PST) From: Jon Simola X-Sender: jon@newmail.netbistro.com To: Peter Pentchev Cc: freebsd-ports@freebsd.org, chris@freebsd.org Subject: Re: ports/converters/fconv fix In-Reply-To: <20001103090631.A323@ringworld.oblivion.bg> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Fri, 3 Nov 2000, Peter Pentchev wrote: > Actually, wouldn't it be easier to just replace strchr() with strrchr()? :) Yep, and after looking at my fix for a while I didn't even manage to get it right. Apologies for the waste of time, and thanks for pointing out the trivial fix. This would be the correct patch: --- fconv.c.orig Mon May 3 12:09:54 1999 +++ fconv.c Thu Nov 2 23:42:12 2000 @@ -114,7 +114,7 @@ } /* Now determine the program to use */ - tprg = strchr(prg, '/'); + tprg = strrchr(prg, '/'); if (tprg != NULL) if ((tprg += 1) != NULL) --- Jon Simola | "In the near future - corporate networks Systems Administrator | reach out to the stars, electrons and light ABC Communications | flow throughout the universe." -- GITS To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message