From owner-freebsd-git@freebsd.org Wed Dec 23 16:47:28 2020 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 633874C46D0 for ; Wed, 23 Dec 2020 16:47:28 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D1Jz34z7Rz3Q0h; Wed, 23 Dec 2020 16:47:27 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 7DA9D3C0199; Wed, 23 Dec 2020 16:47:21 +0000 (UTC) Date: Wed, 23 Dec 2020 16:47:21 +0000 From: Brooks Davis To: Warner Losh Cc: John Baldwin , freebsd-git Subject: Re: Git commit message templates Message-ID: <20201223164721.GA94898@spindle.one-eyed-alien.net> References: <5398f806-42a5-560e-a22c-c5483a0c6f9e@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 4D1Jz34z7Rz3Q0h X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-1.90 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[199.48.129.229:from]; FREEFALL_USER(0.00)[brooks]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; NEURAL_SPAM_SHORT(1.00)[1.000]; SPAMHAUS_ZRD(0.00)[199.48.129.229:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0]; R_SPF_NA(0.00)[no SPF record]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; MAILMAN_DEST(0.00)[freebsd-git] X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Dec 2020 16:47:28 -0000 --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 21, 2020 at 10:33:48AM -0700, Warner Losh wrote: > On Mon, Dec 21, 2020 at 10:28 AM John Baldwin wrote: >=20 > > On 12/17/20 12:58 PM, Ed Maste wrote: > > > On Wed, 16 Dec 2020 at 17:35, John Baldwin wrote: > > >> > > >> The only one I'm not a fan of is the lack of punctuation for the fir= st > > >> sentence. Newspaper headlines also use additional capitalization > > >> (e.g. last word and "significant words"), so the current recommendat= ion > > >> is a mix of things and not fully consistent with either one. > > > > > > Fair point - considering the first line as one would an email subject > > > is probably the best approach. > > > > I agree. Perhaps just say that (rather than newspaper headline) and le= ave > > off the note about punctuation. > > >=20 > Personally, I think we're starting to get a bit over prescriptive here. > Once you have the length down, and have a keyword at the start, you've got > 99% of the benefit. Nobody cares if there's a dot at the end or not, and > it's presence or absence adds no value to other readers. Nobody cares abo= ut > having lots of caps or not. We should just let people use their judgement. While it makes little difference it seems reasonable to make a suggestion here and for it to follow common conventions. IMO there's little value in un-opinionated style guides. There might be something to be said for flagging things that are more or less important. -- Brooks --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJf43SYAAoJEKzQXbSebgfAsqkH/AxLLfFdYGU9/rbVWSvzfAwm 3D+JNKTxEQ4+nHg/UUF4aE6IsR0OrnzztpNW5WLbVEJkEuZ6uEiq+07s42dNS9Q+ rIFKL5X6iagCNbl/ZcIyCHGJy10edP9Incsi5zx/xtDxrWmavWwdYyWtAekmR263 Wvzwtl8Rzbz7ImIqeZ0mUY9wzV0znzn7w1GOL1tCW93cRJ0di1c9wUTq91P2BiKu 4y0NM2+gXKD/J6ioD8+XobU0WyPTcIEKpP+qMRgvg/ZWZg7VdPUrZmhNUKTh0/te yeMgZDQ5cCocedFNZNLNj7rm9rz/UDC8lVOAG8fR3uV67MPOFnjbA2Pk3B/SQFo= =SqPz -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--