From owner-freebsd-doc@FreeBSD.ORG Tue Jan 20 15:10:31 2004 Return-Path: Delivered-To: freebsd-doc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E03E616A4CE for ; Tue, 20 Jan 2004 15:10:30 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D09C43D4C for ; Tue, 20 Jan 2004 15:10:17 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i0KNAHFR080153 for ; Tue, 20 Jan 2004 15:10:17 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i0KNAGIm080152; Tue, 20 Jan 2004 15:10:16 -0800 (PST) (envelope-from gnats) Date: Tue, 20 Jan 2004 15:10:16 -0800 (PST) Message-Id: <200401202310.i0KNAGIm080152@freefall.freebsd.org> To: freebsd-doc@FreeBSD.org From: Ceri Davies Subject: Re: docs/61653: [patch] cleanup after recent changes to Porter's Handbook X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Ceri Davies List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2004 23:10:31 -0000 The following reply was made to PR docs/61653; it has been noted by GNATS. From: Ceri Davies To: Mark Linimon Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: docs/61653: [patch] cleanup after recent changes to Porter's Handbook Date: Tue, 20 Jan 2004 23:04:46 +0000 --6zipuvUKAEymKn2g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 20, 2004 at 04:47:28PM -0600, Mark Linimon wrote: Mark, Please commit this (with my approval), proviso the inline comments below. Thanks for following up on this. > @@ -348,8 +348,19 @@ > Also add a short description of the program you ported > to the Description field of the PR and > the shar or uuencoded tarfile to the > - Fix field. The latter one helps the committers > - a lot, who use scripts for the ports-work. > + Fix field. > + > + > + You can make our work a lot easier, if you use a good > + description in the synopsis of the problem report. > + We prefer something like > + New port: <category>/<portname> > + <short description of the port> for new ports and > + Update port: <category>/<portname> > + <short description of the update> for port updates. > + If you stick to this scheme, the chance that someone takes a > + look at your PR soon is much bigger. s/someone takes/someone will take/, s/bigger/better/ (I can be swayed on the second - your call). > @@ -2793,7 +2793,9 @@ > Set your mail-address here. Please. :-) > =20 > - The format used should be user@hostname.domain. > + Note that only a single address without comment part is > + allowed as a MAINTAINER value. > + The format used should be user@hostname.domain. s/without comment/the comment/ ? > @@ -4634,23 +4636,23 @@ > =20 > If the maintainer asks you to do the upgrade or the maintain= er > is ports@FreeBSD.org, > - please make the upgrade and send the > + please make the upgrade and save the result of the > recursive diff output > of the new and old > - ports directories to us (e.g., if your modified port directory is > + ports directories. (e.g., if your modified port directory is There shouldn't be a period there. > called superedit and the original is in our tree > - as superedit.bak, then send us the result of > + as superedit.bak, then save the result of > diff -ruN superedit.bak superedit). Either > unified or context diff is fine, but port committers generally > prefer unified diffs. Note the use of the -N > option—this is the accepted way to force diff to properly > deal with the case of new files being added or old files being > - deleted. > + deleted. Before sendingus the diff, please examine the > + output to make sure all the changes make sense. s/sendingus/sending us/ Cheers, Ceri --=20 --6zipuvUKAEymKn2g Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFADbQOocfcwTS3JF8RAv2MAJ4iGYYC8K9R4QQIvgz917N0QlBlbACgp4WB d46zQieSUVcjvt+owKeyaWU= =p1NN -----END PGP SIGNATURE----- --6zipuvUKAEymKn2g--