From owner-svn-src-all@freebsd.org Sat Feb 1 09:14:03 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7BE152491FB; Sat, 1 Feb 2020 09:14:03 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id 488pLL2JQXz4Kht; Sat, 1 Feb 2020 09:14:01 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from pjdmacbook.local (c-67-169-9-63.hsd1.ca.comcast.net [67.169.9.63]) by mail.dawidek.net (Postfix) with ESMTPSA id EAFA547; Sat, 1 Feb 2020 10:13:53 +0100 (CET) Subject: Re: svn commit: r357138 - head/bin/pwait To: Jilles Tjoelker , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202001261049.00QAnORw063681@repo.freebsd.org> <6cb2e1c2-f81d-7e06-80a3-a0d7fee00c6a@stack.nl> From: Pawel Jakub Dawidek Autocrypt: addr=pawel@dawidek.net; prefer-encrypt=mutual; keydata= xsFNBFUw6dIBEADZyMuLdzuT7M37zD+2zrTKVZrgLf3jHKd4VOdU+KVj4TvirBXsAGk0Kyld 5dMbjZDxAVKSgviQ6pLvDIwQw/LjwTc/Frbrj0F9DvGCuu1LZKDf5lvL8Kfs/uX8hrsQLmjA dY2Rr6/isDzUBUWH5v2uSxTD9l1h7nvVx+B4gpfe2pYvVOTvEG3UqbjjUT3d0R2L1X8M2f4y T2FqFp2gbuwJT6N6jr+wFheqhltOW5a1e7aO6Ds4Jow1AJ/8vfZ3PHWt7/GE0BIy1oDQLWjK 1UQxpklZLKhCWaJlypYLZDkNbiit/cki1bbkrbdvgtwFzezqndgmpkUU+9QeXaBit2synjka z3f4OwwlilAYwu6NUDdJVavuIyHzbmLfdTIUYzl4Uc/82aChEFWhHvV+mOluURL9870Fz6K9 DoDraymrsyoOeLZ7464ofoRo6iL4DfSEIZt02Tu8glQ7HzB77awzU0hPcR/HPAh7j1jXYH8k IPXDHbKjkm9KHughO1BafKKl8VvWlPOO3dM+BUGaaqCt/ccYie6onvkEJn44Ho8XnlLmWlzy XsVW0NB4uuNLkINkC8dQEel3U4ZEIuseqDiitH0RceIbVypCJjdc+p0pmadNxyhLW/g2IDsM zc8VLpyQz8sXG+2ZeaGkvVpDAuqUj0hxS6lFpCLRgYhF3R2PIQARAQABzSZQYXdlxYIgSmFr dWIgRGF3aWRlayA8cGpkQEZyZWVCU0Qub3JnPsLBfQQTAQoAJwUCVTDqMQIbAwUJCWYBgAUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAAKCRCVS4UrsShbdRTeEACcpbKYbLX4Nh+DWMmoSZ0r C+fD8GB0OKKp5zMyN9PFvEW9AVOQOFA+SWP8Eo0qCMPNVkcRp+7zFvOrDLEjgCs/id7pTZr4 d2el3El04bJH2p62VLemTVBiNf19TRYr9nrZjqOoIB+x7+hwuVQ84HtWCJRBlVpBLY7JnXfO 50jF4E20T9XBElwLfivsG1mEQFNQD/AGiFSEP3HZs06bMjGnLd30C5oTW+NFl2K6urNFAss+ pBO/5ZH4zLhgItjZRMYHU8y4rWeBgUq72pcZEQ8begVC/GUyE7/mGwtJBpOcBIGG3fZkhIqi 3NxRSRrGjQtROA6zubqx/oRWHjl2Wsk6rlFZDUhxBwfoY3tqfPnuIe+vyouZK+/IjXENoeeH VgGScJAaffNUw2qYOJILmjFfp904HG+lNEEU2xYDgRhBWLxx1QKzTleVZSgbsKUF+ib+IofD hbeO4jo3bgRH2zl02Vu0gdxbVf/rZ8ln1M7nIA0eYFNKiv0FXpFNw00O6/9lsB1uRDpvs3Jb 5Zo6e0EzVZBusDB8MJPh7RwuSXbe2KLWPTq/GTu5lhfyFrNtI3tnqEXwqYdbM+8CF2gvlN3F MI75peFXB63j0liVQmt8R/OikyuteVGBSRxsR06NtS/48xBg6Icq3cPeXcv9V0F9KS7spbR8 bfsLFg4p+yO0Hs7BTQRVMOnSARAAsu1DI8OZkVj7TmQ+wy8KD0iWjaiO1eepbqS+sIdOrlXI ++0UfQIi886zU68CrNA/yI6Miu80T3pOaCD6JA0JDGnh/skozlr/fwgdeQf02byVKY4Twx/2 JJBuGxjdEd53apu+FuGPZpD6kJkexq7Q415vUHmRh0vCO0Dr8ChFPgTOm6kzig8NqZwTj6Wj Rm3gbp23TQnkOtWtGp0G9p9VJw6z1j3NPXFmygijbOAX2BdEpnSD6ppLjwRYi9ZafUTZUCiq Dj/dwIOMF3FNOVfcbydPpfxDZEQIBNUTljojve78eLN4np4d7vKR6/DBY4PqsIB05uIMmAGc ebil9tVqcRqc/FU4xH8raZlhtqhGiiOYMFTKzo1gTBLlua0C99XRQo50JFZEIjdJvrlLcfyb caXs4JnKghjrNQT6MwROlsXMFourDuOtJ+6Yv9Zh+1WdIKFfYuQkjNXZYKjcFdyiys6lFpqS kVsuR3y9nS2wj9sYniFToOdXwmaecTjc0v0UYdcYQSyLhSASw7Hqc70bxMVx8YJPZ3q0Gak8 ltpxxVBLsugV4FlEOZHjqzlFS31nFhXgQGEPdh/2QlUd4LEsh5o2wMo22uNad/0MsqKealap Pe0wv0DxV1SPIZc8GEOzah5egjIrZBZs7wxS0c9v2N7aiOVYQYt3ehMCi351Az8AEQEAAcLB ZQQYAQoADwUCVTDp0gIbDAUJCWYBgAAKCRCVS4UrsShbdWhPD/96+OIFTu+Y1j4VTGERHESm C3w8ZN1P4PmfFyNO3JICeXwHkw2sfcHsnsKCstni0q//a3Z1nTZbnCGb02/6wN//FGXlcaA6 gJSWj/Di30hlyO3CDIj/3HxCfsAl6o1fiPL20wxaRRoYPFFbv+bfQQVeoc92NGsu2nE1tQ60 aTuuM+3ZNTWW6PreCW3WdA9QgKA247Sp0jTXbZiIpjXH4byC3EHBHPjGFYQrDedfm88EddWD hCJk16SmrD9B40h0PS1NPTk745fwZp2yfzx6tEcQoHa7SX5EmvZ18HkdzWVUmGPsYK+CJ6ZJ DO4YI4hFZ+1zUPsFYYA6mSHgNnFUa8d/HrFLjU+bFrcOIUhFyw+twISmq97QABbh+045/mqL Mop692EBUc5JrwcqeizGs32Pmjb3glUkkF9M7ssQd33oqwmJYReILIvo9SR4zf8jlNgpM5C0 lCwyAIwUZ7fD1lpS8GmjR9bsLOIEvvO9m+ty1jwkpUv0sNjgLD4XYEM3xJDaevfI7LZTG0yj mkdlMJvk5Oh2kGs89W9xdPehFQnIao52Rp43cDgNx8h86QoKOLdgddn8d6X18tG7oR79Mufj W9+JOHz44OU6H/qCq81zdxmPRdla7+eoyjNatXHlHvTx6HUkbjo1/MBoHQDeCiR3z7yyXq1Q jN7Z51AB9/Ip1Q== Message-ID: <4583631f-13ed-b251-b595-d76eb0e3739d@dawidek.net> Date: Sat, 1 Feb 2020 01:13:51 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <6cb2e1c2-f81d-7e06-80a3-a0d7fee00c6a@stack.nl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 488pLL2JQXz4Kht X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of pawel@dawidek.net has no SPF policy when checking 91.121.88.72) smtp.mailfrom=pawel@dawidek.net X-Spamd-Result: default: False [1.56 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[63.9.169.67.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[dawidek.net]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.87)[0.870,0]; NEURAL_HAM_MEDIUM(-0.43)[-0.433,0]; R_SPF_NA(0.00)[]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:16276, ipnet:91.121.0.0/16, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.12)[ipnet: 91.121.0.0/16(-1.48), asn: 16276(2.07), country: FR(0.00)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Feb 2020 09:14:03 -0000 On 1/30/20 14:47, Jilles Tjoelker wrote: > On 26-01-2020 11:49, Pawel Jakub Dawidek wrote: >> Author: pjd >> Date: Sun Jan 26 10:49:24 2020 >> New Revision: 357138 >> URL: https://svnweb.freebsd.org/changeset/base/357138 >> >> Log: >>    - Be consistent with using sysexits(3) codes. >>    - Turn fprintf()+exit() into errx(). >>       Sponsored by:    Fudo Security >> >> Modified: >>    head/bin/pwait/pwait.c >> >> Modified: head/bin/pwait/pwait.c >> ============================================================================== >> >> --- head/bin/pwait/pwait.c    Sun Jan 26 07:24:49 2020    (r357137) >> +++ head/bin/pwait/pwait.c    Sun Jan 26 10:49:24 2020    (r357138) >> @@ -53,8 +53,7 @@ static void >>   usage(void) >>   { >>   -    fprintf(stderr, "usage: pwait [-t timeout] [-v] pid ...\n"); >> -    exit(EX_USAGE); >> +    errx(EX_USAGE, "usage: pwait [-t timeout] [-v] pid ..."); > > This adds a "pwait: " before the line, which most other programs do not do. > Reverted in r357362. Thanks. -- Pawel Jakub Dawidek