From owner-freebsd-rc@FreeBSD.ORG Mon Jun 1 07:28:16 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AC23C106564A; Mon, 1 Jun 2009 07:28:16 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.freebsd.org (Postfix) with ESMTP id E60378FC14; Mon, 1 Jun 2009 07:28:15 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.3/8.14.3) with ESMTP id n517SECx043426; Mon, 1 Jun 2009 11:28:14 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Mon, 1 Jun 2009 11:28:14 +0400 (MSD) From: Dmitry Morozovsky To: Doug Barton In-Reply-To: <4A23705C.3020603@FreeBSD.org> Message-ID: References: <200905301938.n4UJcpbF017191@svn.freebsd.org> <4A22CFA1.3050408@FreeBSD.org> <4A23705C.3020603@FreeBSD.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-834018739-548216712-1243841294=:42245" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (woozle.rinet.ru [0.0.0.0]); Mon, 01 Jun 2009 11:28:14 +0400 (MSD) Cc: Pawel Jakub Dawidek , freebsd-rc@FreeBSD.org Subject: Re: svn commit: r193112 - head/etc/rc.d X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2009 07:28:17 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---834018739-548216712-1243841294=:42245 Content-Type: TEXT/PLAIN; charset=US-ASCII On Sun, 31 May 2009, Doug Barton wrote: DB> > DB> > DB> As previously advertised, remove this script prior to the 8.0 branch. DB> > DB> > DB> > DB> > Was there an agreement what should one do with dumping to gmirror (see DB> > DB> > sbin/geom/class/mirror/gmirror.8) ? DB> > DB> DB> > DB> I'm not familiar with that issue, but it sounds like something that DB> > DB> needs its own rc.d script. If someone who knows what is supposed to DB> > DB> happen wants to write something up and send it to the freebsd-rc@ list DB> > DB> I'll be glad to help review it. DB> > DB> > Something like (checks should be added, yeah) DB> DB> This is fine, but for consistency with the other stuff in rc.d the DB> name of the script, the value of $name, and the PROVIDE should all be DB> the same. I would name it something like gmsc and in DB> etc/defaults/rc.conf (and probably in the script itself) add a comment DB> indicating what it's for. DB> DB> Not sure what you mean by "checks should be added," I'm not familiar DB> with gmirror at all. But it looks like you're on the right track, yes. Well, I'm ton very familiar with rc.d scripts rules, so I suppose I missed some _rc.d_ checks, but corrected patch is attached. I'm not sure where second part of gmirror configuring process belong though... -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------ ---834018739-548216712-1243841294=:42245 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=gmsc.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=gmsc.patch SW5kZXg6IGRlZmF1bHRzL3JjLmNvbmYNCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0NClJDUyBmaWxlOiAvaG9tZS9uY3ZzL3NyYy9ldGMvZGVmYXVsdHMvcmMu Y29uZix2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzU2DQpkaWZmIC11IC1y MS4zNTYgcmMuY29uZg0KLS0tIGRlZmF1bHRzL3JjLmNvbmYJMjIgTWF5IDIw MDkgMTM6NTY6MTYgLTAwMDAJMS4zNTYNCisrKyBkZWZhdWx0cy9yYy5jb25m CTEgSnVuIDIwMDkgMDc6MjU6NTIgLTAwMDANCkBAIC0yNzYsNiArMjc2LDcg QEANCiANCiByd2hvZF9lbmFibGU9Ik5PIgkJIyBSdW4gdGhlIHJ3aG8gZGFl bW9uIChvciBOTykuDQogcndob2RfZmxhZ3M9IiIJCQkjIEZsYWdzIGZvciBy d2hvZA0KK3J3aG9kX2RlbGF5PSIwIgkJCSMgRGVsYXkgaW4gc2Vjb25kcyBi ZWZvcmUgc3RhcnRpbmcgcndob2QNCiByYXJwZF9lbmFibGU9Ik5PIgkJIyBS dW4gcmFycGQgKG9yIE5PKS4NCiByYXJwZF9mbGFncz0iLWEiCQkjIEZsYWdz IHRvIHJhcnBkLg0KIGJvb3RwYXJhbWRfZW5hYmxlPSJOTyIJCSMgUnVuIGJv b3RwYXJhbWQgKG9yIE5PKS4NCkBAIC01NDYsOCArNTQ3LDcgQEANCiBkdW1w ZGV2PSJBVVRPIgkJIyBEZXZpY2UgdG8gY3Jhc2hkdW1wIHRvIChkZXZpY2Ug bmFtZSwgQVVUTywgb3IgTk8pLg0KIGR1bXBkaXI9Ii92YXIvY3Jhc2giCSMg RGlyZWN0b3J5IHdoZXJlIGNyYXNoIGR1bXBzIGFyZSB0byBiZSBzdG9yZWQN CiBzYXZlY29yZV9mbGFncz0iIgkjIFVzZWQgaWYgZHVtcGRldiBpcyBlbmFi bGVkIGFib3ZlLCBhbmQgcHJlc2VudC4NCi1jcmFzaGluZm9fZW5hYmxlPSJZ RVMiCSMgQXV0b21hdGljYWxseSBnZW5lcmF0ZSBjcmFzaCBkdW1wIHN1bW1h cnkuDQotY3Jhc2hpbmZvX3Byb2dyYW09Ii91c3Ivc2Jpbi9jcmFzaGluZm8i CSMgU2NyaXB0IHRvIGdlbmVyYXRlIGNyYXNoIGR1bXAgc3VtbWFyeS4NCitn bXNjX2VuYWJsZT0iTk8iCSMgSWYgZ21pcnJvciBpcyB1c2VkIGZvciBkdW1w cywgcHJlcGFyZSBpdCBmb3Igc2F2ZWNvcmUNCiBxdW90YV9lbmFibGU9Ik5P IgkjIHR1cm4gb24gcXVvdGFzIG9uIHN0YXJ0dXAgKG9yIE5PKS4NCiBjaGVj a19xdW90YXM9IllFUyIJIyBDaGVjayBxdW90YXMgb24gc3RhcnR1cCAob3Ig Tk8pLg0KIHF1b3Rhb25fZmxhZ3M9Ii1hIgkjIFR1cm4gcXVvdGFzIG9uIGZv ciBhbGwgZmlsZSBzeXN0ZW1zIChpZiBlbmFibGVkKQ0KSW5kZXg6IHJjLmQv TWFrZWZpbGUNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAv aG9tZS9uY3ZzL3NyYy9ldGMvcmMuZC9NYWtlZmlsZSx2DQpyZXRyaWV2aW5n IHJldmlzaW9uIDEuOTcNCmRpZmYgLXUgLXIxLjk3IE1ha2VmaWxlDQotLS0g cmMuZC9NYWtlZmlsZQkzMCBNYXkgMjAwOSAxOTozODo1MSAtMDAwMAkxLjk3 DQorKysgcmMuZC9NYWtlZmlsZQkxIEp1biAyMDA5IDA3OjI1OjUyIC0wMDAw DQpAQCAtMTEsNyArMTEsNyBAQA0KIAlkbWVzZyBkdW1wb24gXA0KIAllbmNz d2FwIFwNCiAJZnNjayBmdHAtcHJveHkgZnRwZCBcDQotCWdiZGUgZ2VsaSBn ZWxpMiBnc3NkIFwNCisJZ2JkZSBnZWxpIGdlbGkyIGdtc2MgZ3NzZCBcDQog CWhjc2VjZCBcDQogCWhvc3RhcGQgaG9zdGlkIGhvc3RuYW1lIFwNCiAJaW5l dGQgaW5pdHJhbmRvbSBcDQpJbmRleDogcmMuZC9nbXNjDQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09DQpSQ1MgZmlsZTogcmMuZC9nbXNjDQpkaWZmIC1OIHJj LmQvZ21zYw0KLS0tIC9kZXYvbnVsbAkxIEphbiAxOTcwIDAwOjAwOjAwIC0w MDAwDQorKysgcmMuZC9nbXNjCTEgSnVuIDIwMDkgMDc6MjU6NTIgLTAwMDAN CkBAIC0wLDAgKzEsMjIgQEANCisjIS9iaW4vc2gNCisjDQorIyAkRnJlZUJT RCQNCisjDQorDQorIyBCRUZPUkU6IHNhdmVjb3JlDQorIyBQUk9WSURFOiBn bXNjDQorIyBLRVlXT1JEOiBub2phaWwNCisNCisuIC9ldGMvcmMuc3Vicg0K Kw0KK25hbWU9Imdtc2MiDQorc3RhcnRfY21kPSJnbXNjX3N0YXJ0Ig0KK3N0 b3BfY21kPSI6Ig0KKw0KK2dtc2F2ZWNvcmVfc3RhcnQoKQ0KK3sNCisJZ21p cnJvciBjb25maWd1cmUgLWIgcHJlZmVyICR7ZHVtcGRldn0NCit9DQorDQor bG9hZF9yY19jb25maWcgJG5hbWUNCitydW5fcmNfY29tbWFuZCAiJDEiDQo= ---834018739-548216712-1243841294=:42245--