Date: Wed, 31 Jul 2024 18:31:18 -0400 From: "Drew Gallatin" <gallatin@fastmail.com> To: "Konstantin Belousov" <kib@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2204a4829083 - main - mlx5en: limit reporting eeprom read failure due to unplugged module to verboseboot Message-ID: <01e60d3e-6564-4af1-874d-677ce68084a1@app.fastmail.com> In-Reply-To: <202407301500.46UF0r39092391@gitrepo.freebsd.org> References: <202407301500.46UF0r39092391@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Thank you!! Drew On Tue, Jul 30, 2024, at 11:00 AM, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2204a4829083bf2a40304ea873d287a5498973d7 > > commit 2204a4829083bf2a40304ea873d287a5498973d7 > Author: Konstantin Belousov <kib@FreeBSD.org> > AuthorDate: 2024-07-26 21:09:58 +0000 > Commit: Konstantin Belousov <kib@FreeBSD.org> > CommitDate: 2024-07-30 15:00:04 +0000 > > mlx5en: limit reporting eeprom read failure due to unplugged module to verboseboot > > Requested by: gallatin > Sponsored by: NVIDIA networking > MFC after: 1 week > --- > sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > index 791e278daaf8..ccbdf11a1dd5 100644 > --- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > @@ -3687,9 +3687,11 @@ out: > /* Check if module is present before doing an access */ > module_status = mlx5_query_module_status(priv->mdev, module_num); > if (module_status != MLX5_MODULE_STATUS_PLUGGED_ENABLED) { > - mlx5_en_err(ifp, > - "Query module %d status: not plugged (%d), eeprom reading is not supported\n", > - module_num, module_status); > + if (bootverbose) > + mlx5_en_err(ifp, > + "Query module %d status: not plugged (%d), " > + "eeprom reading is not supported\n", > + module_num, module_status); > error = EINVAL; > goto err_i2c; > } > [-- Attachment #2 --] <!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Thank you!!<br></div><div><br></div><div>Drew<br></div><div><br></div><div>On Tue, Jul 30, 2024, at 11:00 AM, Konstantin Belousov wrote:<br></div><blockquote type="cite" id="qt" style=""><div>The branch main has been updated by kib:<br></div><div><br></div><div>URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=2204a4829083bf2a40304ea873d287a5498973d7">https://cgit.FreeBSD.org/src/commit/?id=2204a4829083bf2a40304ea873d287a5498973d7</a><br></div><div><br></div><div>commit 2204a4829083bf2a40304ea873d287a5498973d7<br></div><div>Author: Konstantin Belousov <<a href="mailto:kib@FreeBSD.org">kib@FreeBSD.org</a>><br></div><div>AuthorDate: 2024-07-26 21:09:58 +0000<br></div><div>Commit: Konstantin Belousov <<a href="mailto:kib@FreeBSD.org">kib@FreeBSD.org</a>><br></div><div>CommitDate: 2024-07-30 15:00:04 +0000<br></div><div><br></div><div> mlx5en: limit reporting eeprom read failure due to unplugged module to verboseboot<br></div><div> <br></div><div> Requested by: gallatin<br></div><div> Sponsored by: NVIDIA networking<br></div><div> MFC after: 1 week<br></div><div>---<br></div><div>sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 8 +++++---<br></div><div>1 file changed, 5 insertions(+), 3 deletions(-)<br></div><div><br></div><div>diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c<br></div><div>index 791e278daaf8..ccbdf11a1dd5 100644<br></div><div>--- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c<br></div><div>+++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c<br></div><div>@@ -3687,9 +3687,11 @@ out:<br></div><div>/* Check if module is present before doing an access */<br></div><div>module_status = mlx5_query_module_status(priv->mdev, module_num);<br></div><div>if (module_status != MLX5_MODULE_STATUS_PLUGGED_ENABLED) {<br></div><div>- mlx5_en_err(ifp,<br></div><div>- "Query module %d status: not plugged (%d), eeprom reading is not supported\n",<br></div><div>- module_num, module_status);<br></div><div>+ if (bootverbose)<br></div><div>+ mlx5_en_err(ifp,<br></div><div>+ "Query module %d status: not plugged (%d), "<br></div><div>+ "eeprom reading is not supported\n",<br></div><div>+ module_num, module_status);<br></div><div>error = EINVAL;<br></div><div>goto err_i2c;<br></div><div>}<br></div><div><br></div></blockquote></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01e60d3e-6564-4af1-874d-677ce68084a1>