Date: Wed, 10 Jun 1998 22:09:31 +1000 From: Bruce Evans <bde@zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, dt@FreeBSD.ORG Subject: Re: cvs commit: src/sys/msdosfs msdosfs_vnops.c Message-ID: <199806101209.WAA17030@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Modified files: > sys/msdosfs msdosfs_vnops.c > Log: > Also return EOPNOTSUPP rather than EINVAL for not supported owner and group > changes. This is wrong in several ways: - the operation is supported, but certain values are invalid. - EOPNOTSUPP is not mentioned in chown.2 or chgrp.2. EINVAL is documented as the error for fchown() on a socket. - EOPNOTSUPP is not a POSIX errno. Although msdosfs can't support full POSIX semantics, it should be as POSIX-like as possible Chflags doesn't have so much history beind not returning EOPNOTSUPP, but EOPNOTSUPP is not mentioned in chflags.2 and EINVAL is documented as the error for fchflags() on a socket. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199806101209.WAA17030>