From owner-svn-src-head@freebsd.org Thu Jul 19 20:48:25 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A7E8104A4DE; Thu, 19 Jul 2018 20:48:25 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47FDE7B746; Thu, 19 Jul 2018 20:48:23 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from [IPv6:2001:67c:370:128:91bf:6c2e:4974:1f76] (unknown [IPv6:2001:67c:370:128:91bf:6c2e:4974:1f76]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 64253721E282F; Thu, 19 Jul 2018 22:48:20 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r336503 - in head/sys: netinet netinet6 From: Michael Tuexen In-Reply-To: <20180719202738.GA69018@FreeBSD.org> Date: Thu, 19 Jul 2018 16:48:18 -0400 Cc: cem@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Transfer-Encoding: 7bit Message-Id: <4E76E1DC-DB70-47D1-A59D-E99058C00D53@freebsd.org> References: <201807191933.w6JJXhof018383@repo.freebsd.org> <20180719202738.GA69018@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.3445.9.1) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 20:48:25 -0000 > On 19. Jul 2018, at 16:27, Alexey Dokuchaev wrote: > > On Thu, Jul 19, 2018 at 04:23:27PM -0400, Michael Tuexen wrote: >>> On 19. Jul 2018, at 16:11, Conrad Meyer wrote: >>> These changes mostly seem like style regressions, rather than >>> improvements. (Not to mention, largescale churn like this makes it >>> more difficult for future readers to research history (confusing tools >>> like "git/svn blame").) >> >> We have upstream code and run this to an formatter tool which depends >> on ident, which has been changed recently. Unfortunately, I also ran >> an older version of the script, so I reverted this in >> https://svnweb.freebsd.org/changeset/base/336508 >> and committed a version really only showing the differences related to >> the ident changes in >> https://svnweb.freebsd.org/changeset/base/336511 > > Thanks for fixing, but you might find doing "svn diff" prior to commit > very handy next time (no offense). I did actually making sure the there are only whitespace changes. However, I just take what the tool produces (for years). Only after doing svn diff for a functional change, where no whitespace changes should be, but actually were, I realised my usage error and reverted... Best regards Michael > > ./danfe