From owner-svn-src-projects@FreeBSD.ORG Tue Jan 11 12:20:29 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ADD941065675 for ; Tue, 11 Jan 2011 12:20:29 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 2E80F8FC1D for ; Tue, 11 Jan 2011 12:20:28 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p0BBnfI5091617 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Jan 2011 13:49:41 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p0BBneTs011948; Tue, 11 Jan 2011 13:49:40 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p0BBnexg011947; Tue, 11 Jan 2011 13:49:40 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 11 Jan 2011 13:49:40 +0200 From: Kostik Belousov To: Dimitry Andric Message-ID: <20110111114940.GG2518@deviant.kiev.zoral.com.ua> References: <201101111048.p0BAmowJ017937@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+sHJum3is6Tsg7/J" Content-Disposition: inline In-Reply-To: <201101111048.p0BAmowJ017937@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217260 - projects/binutils-2.17/contrib/binutils/ld/emultempl X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2011 12:20:29 -0000 --+sHJum3is6Tsg7/J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 11, 2011 at 10:48:50AM +0000, Dimitry Andric wrote: > Author: dim > Date: Tue Jan 11 10:48:50 2011 > New Revision: 217260 > URL: http://svn.freebsd.org/changeset/base/217260 >=20 > Log: > Put in a temporary kludge to force ld to put .note sections just after > .interp sections. This seems to have been broken by binutils commit > 7f55fa5745fbe04b91e1fbd668d102f3166e03d8, but the specific reasons are > still unclear. > =20 > For now, this fix is needed to make sure .note.ABI-tag sections always > end up in the first page of the resulting executable. >=20 > Modified: > projects/binutils-2.17/contrib/binutils/ld/emultempl/elf32.em >=20 > Modified: projects/binutils-2.17/contrib/binutils/ld/emultempl/elf32.em > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- projects/binutils-2.17/contrib/binutils/ld/emultempl/elf32.em Tue Jan= 11 06:07:36 2011 (r217259) > +++ projects/binutils-2.17/contrib/binutils/ld/emultempl/elf32.em Tue Jan= 11 10:48:50 2011 (r217260) > @@ -1540,8 +1540,7 @@ gld${EMULATION_NAME}_place_orphan (asect > if ((s->flags & SEC_ALLOC) =3D=3D 0) > ; > else if ((s->flags & SEC_LOAD) !=3D 0 > - && ((iself && sh_type =3D=3D SHT_NOTE) > - || (!iself && CONST_STRNEQ (secname, ".note")))) > + && CONST_STRNEQ (secname, ".note")) I am not sure, but it looks likely that (iself && sh_type =3D=3D SHT_NOTE) part of condition better be kept. > place =3D &hold[orphan_interp]; > else if ((s->flags & (SEC_LOAD | SEC_HAS_CONTENTS)) =3D=3D 0) > place =3D &hold[orphan_bss]; --+sHJum3is6Tsg7/J Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk0sQ9QACgkQC3+MBN1Mb4jR8ACg4c8WuAO40cULeyqrT0SUQ7SO 0qIAoPOH8YheoZwY3UBrEXVeGp4vAfBH =XlrW -----END PGP SIGNATURE----- --+sHJum3is6Tsg7/J--