From owner-freebsd-doc@FreeBSD.ORG Wed Jul 14 15:33:00 2004 Return-Path: Delivered-To: freebsd-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A0B416A4CE; Wed, 14 Jul 2004 15:33:00 +0000 (GMT) Received: from msgbas2x.cos.agilent.com (msgbas2x.cos.agilent.com [192.25.240.37]) by mx1.FreeBSD.org (Postfix) with ESMTP id 81BB543D45; Wed, 14 Jul 2004 15:32:54 +0000 (GMT) (envelope-from des@des.no) Received: from enccos4.cos.agilent.com (enccos4.cos.agilent.com [130.29.152.93]) by msgbas2x.cos.agilent.com (Postfix) with SMTP id B5264838A; Wed, 14 Jul 2004 09:32:53 -0600 (MDT) Received: from relcos2.cos.agilent.com (130.29.152.237) by enccos4.cos.agilent.com (Sigaba Gateway v3.83) with ESMTP id 11661611; Wed, 14 Jul 2004 09:33:16 -0600 Received: from wcosbh22.cos.agilent.com (wcosbh22.cos.agilent.com [130.29.152.178]) by relcos2.cos.agilent.com (Postfix) with ESMTP id D490F603; Wed, 14 Jul 2004 09:32:52 -0600 (MDT) Received: from wcosbh23.cos.agilent.com ([130.29.152.145]) by wcosbh22.cos.agilent.com with Microsoft SMTPSVC(5.0.2195.6713); Wed, 14 Jul 2004 09:32:51 -0600 Received: from mail pickup service by wcosbh23.cos.agilent.com with Microsoft SMTPSVC; Wed, 14 Jul 2004 09:32:50 -0600 Received: from wcosvs23.cos.agilent.com ([130.29.152.143]) by wcosbh23.cos.agilent.com with Microsoft SMTPSVC(5.0.2195.6713); Tue, 6 Jul 2004 08:47:29 -0600 Received: from relcos2.cos.agilent.com ([130.29.152.237]) by 130.29.152.143 with trend_isnt_name_B; Tue, 06 Jul 2004 08:47:23 -0600 Received: from enccos4.cos.agilent.com (enccos4.cos.agilent.com [130.29.152. ; Tue, 6 Jul 2004 08:47:23 -0600 (M DT) Received: from msgbas1x.cos.agilent.com (192.168.148.33)by enccos4.cos.agile nt.com (Sigaba Gateway v3.8)with ESMTP id 8182820; Tue, 06 Jul 2004 08:47:4 4 -0600 Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119])by msgbas1 ; Tue, 6 Jul 2004 08:47:23 -0600 (MDT) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18])by mx2.free bsd.org (Postfix) with ESMTPid CC3B456274; Tue, 6 Jul 2004 14:47:10 +0000 (GMT)(envelope-from owner-freebsd-hackers@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1])by hub.freebsd.org (Po stfix) with ESMTPid EDFF116A4CE; Tue, 6 Jul 2004 14:47:09 +0000 (GMT) Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])by hub.fre ebsd.org (Postfix) with ESMTPid 58C6E16A4CE; Tue, 6 Jul 2004 14:47:02 +000 0 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31])by mx1.FreeBSD.org (Postfix) with ESMTPid B3BF943D55; Tue, 6 Jul 2004 14:47:01 +0000 (GMT)(en velope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666)id 8F015531C; Tue, 6 Jul 2004 16:47:00 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37])by smtp.des.no (Pony Expre ss) with ESMTPid 0B212531B; Tue, 6 Jul 2004 16:46:53 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602)id DCB9DB860; Tue, 6 Jul 2004 16:46:52 +0200 (CEST) To: Xin LI References: <20040625033718.GA1691@frontfree.net> <20040706144102.GA4034@frontfree.net> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?= ) Date: Tue, 06 Jul 2004 16:46:52 +0200 In-Reply-To: <20040706144102.GA4034@frontfree.net> (Xin LI's message of"Tue, 6 Jul 2004 22:41:02 +0800") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Sender: owner-freebsd-hackers@freebsd.org Errors-To: owner-freebsd-hackers@freebsd.org X-OriginalArrivalTime: 06 Jul 2004 14:47:32.0527 (UTC) FILETIME=[2B2C03F0:01C46368] cc: hackers@FreeBSD.org cc: doc@FreeBSD.org Subject: Re: About rules on style changes X-BeenThere: freebsd-doc@freebsd.org List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2004 15:33:00 -0000 Xin LI writes: > Hmm... Seems that I have misunderstood the committers' guide, section > 10.3, which said: > > "Do not mix style fixes with new functionality. A style fix is any > change which does not modify the functionality of the code. Mixing the > changes obfuscates the functionality change when using cvs diff, which > can hide any new bugs." That just means you have to do it in a separate commit. We do not generally make style changes for their own sake; instead, we commit style fixes shortly before or after a functional change. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no _______________________________________________ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"