From owner-svn-src-head@freebsd.org Thu Jul 5 17:55:36 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 090981042CC8; Thu, 5 Jul 2018 17:55:36 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B06EF8CE1C; Thu, 5 Jul 2018 17:55:35 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f45.google.com (mail-it0-f45.google.com [209.85.214.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 72AFC839D; Thu, 5 Jul 2018 17:55:35 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f45.google.com with SMTP id o5-v6so13159815itc.1; Thu, 05 Jul 2018 10:55:35 -0700 (PDT) X-Gm-Message-State: APt69E0KRLGpwdgCyVwyYGU7UKDxIMU693Dz7ZZ8IHIwb+mfPTvNqSaq C8qLEjbjCMbuQpAzj5cqbGBj0kUCw1y/eETFRGM= X-Google-Smtp-Source: AAOMgpc+mJGLQedLMAABN5f0bL/hYb+2HJ/Us/KQN5tYzHOOmgns33fXcgcXD0P4CEgvTgic0jf1cl53GNzq3KPN7KM= X-Received: by 2002:a24:8ac1:: with SMTP id v184-v6mr5614674itd.7.1530813334676; Thu, 05 Jul 2018 10:55:34 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:8d2:0:0:0:0:0 with HTTP; Thu, 5 Jul 2018 10:55:34 -0700 (PDT) In-Reply-To: <20180705155417.GI5562@kib.kiev.ua> References: <201807032305.w63N5guY063293@repo.freebsd.org> <20180704142233.GB5562@kib.kiev.ua> <6e5bc5e4-052c-877f-1c36-c72e276ff045@FreeBSD.org> <20180705155417.GI5562@kib.kiev.ua> From: Matthew Macy Date: Thu, 5 Jul 2018 10:55:34 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r335916 - head/sys/conf To: Konstantin Belousov Cc: John Baldwin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 17:55:36 -0000 On Thu, Jul 5, 2018 at 8:54 AM, Konstantin Belousov wrote: > On Thu, Jul 05, 2018 at 07:56:22AM -0700, John Baldwin wrote: >> On 7/4/18 7:22 AM, Konstantin Belousov wrote: >> > On Tue, Jul 03, 2018 at 11:05:42PM +0000, Matt Macy wrote: >> >> Author: mmacy >> >> Date: Tue Jul 3 23:05:42 2018 >> >> New Revision: 335916 >> >> URL: https://svnweb.freebsd.org/changeset/base/335916 >> >> >> >> Log: >> >> Enable MODULE_TIED by default for modules compiled with the kernel >> > But why ? >> >> I think we should enable KLD_TIED to inline critical_* etc. for modules >> built as part of a kernel that are installed alongside the kernel in /boot/. > >> I don't think we need to support modules built with kernel A loaded into kernel B. >> > This is the crusial point. I do not object, but this this is a radical > change from the previous mode of modules build. > > I do not want to put words in other person mouth, but I beliee that the > original intent of KLD_TIED/MODULE_TIED was much more limited. Only some > specific modules were to be tied. My intention was only to allow it for select modules compiled _with_ the kernel. Then there was a heated discussion about documentation and how to communicate it's distinction with DECLARE_MODULE_TIED. In response to which John said (assuming I understood correctly, communication is hard) that it should be the default and specified doing it the way I did it. That seemed reasonable - but I don't have strong feelings one way or the other. I apologize if I misunderstood any guidance I was provided. -M