From owner-freebsd-current@FreeBSD.ORG  Mon Aug 29 20:19:21 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 34641106566C;
	Mon, 29 Aug 2011 20:19:21 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 486C48FC14;
	Mon, 29 Aug 2011 20:19:19 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id XAA13335;
	Mon, 29 Aug 2011 23:19:08 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1Qy8IW-0001qd-KJ; Mon, 29 Aug 2011 23:19:08 +0300
Message-ID: <4E5BF43A.5050306@FreeBSD.org>
Date: Mon, 29 Aug 2011 23:19:06 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:6.0) Gecko/20110819 Thunderbird/6.0
MIME-Version: 1.0
To: Marcel Moolenaar <marcel@xcllnt.net>
References: <4E580B14.7090208@FreeBSD.org>
	<1A828073-1D5F-4850-9379-4AB62CF3DAE3@xcllnt.net>
	<4E5B4BFB.9040907@FreeBSD.org>
	<E2FDBF46-8DA6-4D13-B5B5-7EB22C220F9D@xcllnt.net>
In-Reply-To: <E2FDBF46-8DA6-4D13-B5B5-7EB22C220F9D@xcllnt.net>
X-Enigmail-Version: undefined
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Marcel Moolenaar <marcel@FreeBSD.org>,
	FreeBSD-Current <freebsd-current@FreeBSD.org>
Subject: Re: possible mountroot regression
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Aug 2011 20:19:21 -0000

on 29/08/2011 19:45 Marcel Moolenaar said the following:
> 
> On Aug 29, 2011, at 1:21 AM, Andriy Gapon wrote:
> 
>> on 27/08/2011 18:16 Marcel Moolenaar said the following:
>>>
>>> On Aug 26, 2011, at 2:07 PM, Andriy Gapon wrote:
>>>
>>>>
>>>> It seems that after the introduction of the mountroot scripting language a user
>>>> now has exactly one chance to try to specify a correct root device at the
>>>> mountroot prompt.  I am not sure that that is convenient/enough.
>>>
>>> This is no different from before.
>>
>> Are you sure?
>> I remember trying multiple (incorrect) possibilities at the prompt and not
>> getting the panic.  But I know that sometimes I have cases of "false memories",
>> so _I_ am not sure.
> 
> I'm sure now that we're both not sure :-)
> 
> It's possible the failure mode varied by how the root mount
> failed...


Judging from the code before r214006 it shouldn't have panic-ed upon such a failure:
static int
vfs_mountroot_ask(void)
{
        char name[128];
        char *mountfrom;
        char *options;

        for(;;) {
...
                gets(name, sizeof(name), 1);
                if (name[0] == '\0')
                        return (1);
                if (name[0] == '?') {
                        printf("\nList of GEOM managed disk devices:\n  ");
                        g_dev_print();
                        continue;
                }
                if (!vfs_mountroot_try(name, NULL))
                        return (0);
        }
}


So this "endless" loop was exited only if vfs_mountroot_try() returned success
(error == 0) or if a user entered an empty string.

-- 
Andriy Gapon