From owner-cvs-all@FreeBSD.ORG Fri Aug 15 11:42:38 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31F1037B405 for ; Fri, 15 Aug 2003 11:42:38 -0700 (PDT) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 6EA8B43FBF for ; Fri, 15 Aug 2003 11:42:36 -0700 (PDT) (envelope-from silby@silby.com) Received: (qmail 65073 invoked from network); 15 Aug 2003 18:42:32 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay.pair.com with SMTP; 15 Aug 2003 18:42:32 -0000 X-pair-Authenticated: 209.68.2.70 Date: Fri, 15 Aug 2003 13:41:42 -0500 (CDT) From: Mike Silbersack To: Sam Leffler In-Reply-To: <76344918.1060937662@melange.errno.com> Message-ID: <20030815133943.I1565@odysseus.silby.com> References: <200308150634.h7F6Ylxw022089@repoman.freebsd.org> <76344918.1060937662@melange.errno.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/libkern arc4random.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Aug 2003 18:42:38 -0000 On Fri, 15 Aug 2003, Sam Leffler wrote: > > Lock down arc4random so it can be safely called w/o Giant. > > > > Minor code reorganization was required, but the only functional > > change was that the first 1024 bytes of output are thrown out > > after each reseed, rather than just the initial seed. > > How did you validate the this change? I strongly suggest that mods like > this need review before commit. Subtle problems can go unnoticed for a > long time. > > Sam I'm fairly confident that I did not add any bugs in this commit. However, I also have no way of knowing if arc4random was working correctly before the commit either... How hard would it be to hook up the randomness testing code you committed a few months back? If the testing code is in userland, perhaps we could export a /dev/arandom like openbsd does for simpler testing. Mike "Silby" Silbersack