From owner-svn-src-head@FreeBSD.ORG Sat Jul 13 18:34:02 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 258ADCED; Sat, 13 Jul 2013 18:34:02 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-lb0-x236.google.com (mail-lb0-x236.google.com [IPv6:2a00:1450:4010:c04::236]) by mx1.freebsd.org (Postfix) with ESMTP id D294D1C38; Sat, 13 Jul 2013 18:34:00 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id r11so8461710lbv.13 for ; Sat, 13 Jul 2013 11:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=9ntxM2iTFFhuvinuR4rwUGJcJ3yNYFNnzgAVIKFf/Cg=; b=L4PK65Bkn4ON9zc8d8OQcBq1JvDYk+zUz6JKOaapB3l3xX5ftlMql8FMSXtg18oQKf n9716JwP9bDY8wsXw2xsChozaZvYHUL5Vt31Naqavj19vqA2J7VPqbvro70qyCPMGgcP B2jZv/tg3Z6y7r8iqcqH0PfkaZmj7/WxoCqScLfW5r/WzhGS6ViHWRo3rAgSBoQG2hqx 1fqeGC6L0XIQi7ASqLFbNcAuyW6TUWz6cUNwB8LmVde7yIyB1FYyc2Hb88D4BH95rdwl PQC+5EUhlvmXq6a1P/pKLgT3IoEY8r+v/uqU9FBf51X0uE6J0FX86FBZcZ/vKTLvaQ3f 1JwA== X-Received: by 10.112.11.162 with SMTP id r2mr21415316lbb.41.1373740439724; Sat, 13 Jul 2013 11:33:59 -0700 (PDT) Received: from localhost ([178.150.115.244]) by mx.google.com with ESMTPSA id am8sm16369489lac.1.2013.07.13.11.33.57 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 13 Jul 2013 11:33:58 -0700 (PDT) Sender: Mikolaj Golub Date: Sat, 13 Jul 2013 21:33:56 +0300 From: Mikolaj Golub To: Craig Rodrigues Subject: Re: svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt Message-ID: <20130713183354.GA2832@gmail.com> References: <20130712202710.GB2757@gmail.com> <20130713073118.GC2757@gmail.com> <20130713111825.GE2757@gmail.com> <20130713141802.GG2757@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd , src-committers@freebsd.org, Marko Zec X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jul 2013 18:34:02 -0000 On Sat, Jul 13, 2013 at 11:04:23AM -0700, Craig Rodrigues wrote: > Can you try this combination of patches: > > (1) Combine Adrian and Marko's patches, but omit Marko's changes to > kldload/kldunload: > > http://people.freebsd.org/~rodrigc/vnet-patch-adrian+marko.txt > > (2) Revert my Bluetooth patch: > > http://people.freebsd.org/~rodrigc/patch-revert-GRN-253255.txt Currently I don't have any pluggable device so my testing would not be very useful. I tried Marko's patch to test kldload/kldunload change, which is not in your patch. Concerning your combined patch, as I said previously I don't like very much that dance with is_default_vnet. What is a purpose of it? As for me, it only makes the code less readable. I would just set curvnet to vnet0, as it is in Marko's patch. -- Mikolaj Golub