From owner-freebsd-current Sun Feb 9 11:56:43 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31C3F37B401 for ; Sun, 9 Feb 2003 11:56:42 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id B6A1F43F3F for ; Sun, 9 Feb 2003 11:56:41 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 89AF9AE25C; Sun, 9 Feb 2003 11:56:39 -0800 (PST) Date: Sun, 9 Feb 2003 11:56:39 -0800 From: Alfred Perlstein To: David Malone Cc: "M. Warner Losh" , current@FreeBSD.ORG Subject: Re: syslog bug Message-ID: <20030209195639.GS88781@elvis.mu.org> References: <20030208210824.GK88781@elvis.mu.org> <20030209.093600.122405559.imp@bsdimp.com> <20030209180002.GR88781@elvis.mu.org> <20030209180452.GA46269@walton.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030209180452.GA46269@walton.maths.tcd.ie> User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * David Malone [030209 10:04] wrote: > On Sun, Feb 09, 2003 at 10:00:02AM -0800, Alfred Perlstein wrote: > > Heh, the format string is passed through printf later, we don't want > > to eat the extra % otherwise it will cause problems for us. > > I had exactly the same thought as Warner last night, but then > realised that we were about to call printf on the string. Could it > be worth adding a comment, to indicate it is not a dittographic > error? Yes. I'll test and commit shortly. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message