From nobody Fri Mar 7 16:44:45 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z8XFV47KVz5pZTg; Fri, 07 Mar 2025 16:44:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z8XFT6YwGz44FS; Fri, 07 Mar 2025 16:44:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741365885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lT4S0uJLNKxvEuT6TzP2UrH85wVukBGKxrKd98vTI5Q=; b=gN6KOL6KmZdu4R1ZbBs1XMXaFSkFr5D980RYBa0n+jTPcjjhbVJojPAaPXzjbhFaqe05Vs s8pHceMMtyeHgLaFQ7C1xp+/g9CHfDUvH7k3+P36WTIcy4WGgR0bbuHENQ8HTb5FbavHp3 ReiTVTVHAH0/ceJnwUf9NHh7h63+z07xMTK2r1vCy5rzqigv3EV6RM6EwqeZXCZuWp6UXk qxs6us56i+AK5n2/vHvhoc8qFiHzBL8Ro4MploWUBqCIhc02+dDOvAXS4p8nAErjN14dwf 3x+vjKfkCOm1Y+f13EhZhMnVmpnj6L+KCvDsAC02RrlmmuIt2SkqWhhMzzY5Lw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741365885; a=rsa-sha256; cv=none; b=L5R5l68LMKmARgtpMgPB7IFns+4pMdkY97GGdRX+g48gWdsqD/Vt+yvN+w9WTk1EzCeaQ6 ndbG+dXHJVyC0mmp2zFKVNafjhjxkRwNzMXOJMQXaf4cRLuGAD6aKr+WGzlh+8tCXxOoJA YfP4v1sCyTUI6mj0AoxIolcAiMuZz0udCdWoWpdrjdcobEfbuYWoO7ihalUQD7Y22U+awJ hz/K3ggJ5scAlcJ3PtQ/qwkqB7qeRsPOf4waEFLJa6NYaBT2kJMXQdGBzWRpNgbY8bqBUI oYM3jrlpXfHEssf1inIXTVLR8DLWrxj1HDA+bcdRhpjGCFJ/fsurXbpapnmgWg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741365885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lT4S0uJLNKxvEuT6TzP2UrH85wVukBGKxrKd98vTI5Q=; b=Q9n0uq1R/xqwqQ2Wenq7JAgW2bdgeTkUy1EjBNAKkrKMWGJC12ucx+G/cjavSUTew+TZvp 9RBLhrQv0ubcj0RWnkWve6/t/XFZmJ2KCO2LgUW8JugCWOwClrkNVX4G71agb3e2aNC3qX QcYS6WI14UhfUIksFjLr96SbXwKqvBU7O+p2ANd0BNmqbIV6MqF7o0JLvqS8U1r0tOiilU g1uvgdqZE4fWwra4farg0OH4CkDUPQZxc1Bc0KpNALH+F8jHfCjHGiCAaYX4W5Gf2ugj1L DgRBQyC03SvbqIpkz4GoQ7SaKL4s+7GaLUlhWxUsSZfHdQtcQ7v6sjgOn4gn0Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z8XFT61MZzlmx; Fri, 07 Mar 2025 16:44:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 527Gijbl052237; Fri, 7 Mar 2025 16:44:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 527GijUe052234; Fri, 7 Mar 2025 16:44:45 GMT (envelope-from git) Date: Fri, 7 Mar 2025 16:44:45 GMT Message-Id: <202503071644.527GijUe052234@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: ef446a8065ac - main - smbios: style(9): smbios_cksum() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ef446a8065ac0228a5da15f233cd2f964e4d7433 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=ef446a8065ac0228a5da15f233cd2f964e4d7433 commit ef446a8065ac0228a5da15f233cd2f964e4d7433 Author: Olivier Certner AuthorDate: 2025-03-04 16:29:22 +0000 Commit: Olivier Certner CommitDate: 2025-03-07 16:42:47 +0000 smbios: style(9): smbios_cksum() Reduce some variables' lifecycle. Remove useless casts. Remove superfluous braces. Add some consts. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation --- sys/dev/smbios/smbios.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/sys/dev/smbios/smbios.c b/sys/dev/smbios/smbios.c index ca329c0f65f6..469e5ab649b6 100644 --- a/sys/dev/smbios/smbios.c +++ b/sys/dev/smbios/smbios.c @@ -338,25 +338,24 @@ smbios_eps3 (void *v) static int smbios_cksum (void *v) { - struct smbios3_eps *eps3; - struct smbios_eps *eps; - u_int8_t *ptr; + const u_int8_t *ptr; u_int8_t cksum; u_int8_t length; int i; if (smbios_eps3(v)) { - eps3 = (struct smbios3_eps *)v; + const struct smbios3_eps *eps3 = v; + length = eps3->length; } else { - eps = (struct smbios_eps *)v; + const struct smbios_eps *eps = v; + length = eps->length; } - ptr = (u_int8_t *)v; + ptr = v; cksum = 0; - for (i = 0; i < length; i++) { + for (i = 0; i < length; i++) cksum += ptr[i]; - } return (cksum); }