From owner-dev-commits-src-main@freebsd.org Fri Mar 5 18:36:38 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4CE98562E96; Fri, 5 Mar 2021 18:36:38 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dsbzp1HKcz3HXW; Fri, 5 Mar 2021 18:36:38 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qv1-xf29.google.com with SMTP id 2so1498600qvd.0; Fri, 05 Mar 2021 10:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+Szi4fsAA/NFPZgOBYl2/WnzQJT323ztjiiuA4xSqEo=; b=tkQAenj1/0WGpCiyPZ8OqbaGUCI5SnmcPxX2XxlWjW9GUlVPafdjQiS4APgxpe6Vjz w1elFZKJxvTa5y+9SgaIf6UA0tDQkKCN2IStYAR2ejgIfWTekWjdI815m1rXdqURd+PS 53tZK3BQCAyavoZkPP8n11clxRRB3UWOU7XG2klsfkjB6JAaSCI66fpMujB1JlB3q1bL KYwMwgO6zPRLx5392qnzBm2cfPtxvakEiWPwaGBliv2ZrzEpMAeFNcWBESGSKUXoNb4D UQIKOoRAZs57cZq6sBrq+W+Xtw+oae5XH/E1HQl+Re7QwreR7nhWsTEbV1r7kTQq3JNI fXEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=+Szi4fsAA/NFPZgOBYl2/WnzQJT323ztjiiuA4xSqEo=; b=gahnWhU2h1niM0qeMV+6I4UOPC2zQFNy5N2SJJtcAPpSpVekGCDcFRiGkM2e5fcXAJ Hh6J2+bwncxaiYQyU3qpaZ7zmhQ7a8OxfAq2fKJ7aNy0abEPG02HTmE90P3LxyLmmjcC khaVI+q/+kjDdyvs6XXka+LColbDcGmEl0RzJb1zXKuJKSExUkCRfEO9OjxMoNVgYaVA paWFjpRm6ltmhmFwL6Y0mupV8l0YiSRXWTLK2gXESqeTsQACF15b3pWDuJcE/6tdrOF/ 690kYMG0iH4yEZWba8NLb9uPZPMyu1hY/gqfySuSu1yqxzoRWwtCjo7d1CtFPNBrijV9 Ka3g== X-Gm-Message-State: AOAM533UyaUBOr65k4fnUR8kIPPdZfh46xzUSgH3pOUhAooZqv/wFm0A qqraWWOLH4OZbxWaHaPX9LSqPfEAFhVneQ== X-Google-Smtp-Source: ABdhPJxz92ghPsIBL7O2OvTd5ak4JdvzMnQUnU1EKZiTRlsK5COqE0iRZofzxvNR8cLelWW7ys4mIQ== X-Received: by 2002:a0c:be86:: with SMTP id n6mr10167295qvi.61.1614969397036; Fri, 05 Mar 2021 10:36:37 -0800 (PST) Received: from nuc ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id j7sm2344774qtr.70.2021.03.05.10.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 10:36:36 -0800 (PST) Sender: Mark Johnston Date: Fri, 5 Mar 2021 13:36:36 -0500 From: Mark Johnston To: Gordon Bergling Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 89b650872bba - main - ktls: Hide initialization message behind bootverbose Message-ID: References: <202103051815.125IFDNK001016@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4Dsbzp1HKcz3HXW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 18:36:38 -0000 On Fri, Mar 05, 2021 at 07:23:56PM +0100, Gordon Bergling wrote: > Hi Mark, > > is this change not a little bit to aggressive in terms of dmesg cleanup? > > There are a lot messages about what subsystem is initialized with > how many threads, like for example TCP HTPS and TCP BBR. I would argue that that is the exception rather than the norm, and they should be cleaned up too. I just didn't notice since they are not compiled into the kernel. We don't log messages about bufspace threads, taskqueue threads, crypto worker threads, NFSD threads, netgraph threads, pagedaemon threads, etc. This is really an implementation detail and I don't see why it's crucial information that needs to be printed upon each boot. Especially in this case, where KTLS needs to be explicitly be enabled before those threads will ever do anything. > Hiding this information could be suboptimal for some users. There is a kern.ipc.tls.stats.threads sysctl which exposes the same number, so I'm not sure it's really hidden. But why would a user need this information? > On Fri, Mar 05, 2021 at 06:15:13PM +0000, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=89b650872bba2e4bfbc94a200946b461ef69ae22 > > > > commit 89b650872bba2e4bfbc94a200946b461ef69ae22 > > Author: Mark Johnston > > AuthorDate: 2021-03-05 18:11:02 +0000 > > Commit: Mark Johnston > > CommitDate: 2021-03-05 18:11:02 +0000 > > > > ktls: Hide initialization message behind bootverbose > > > > We don't typically print anything when a subsystem initializes itself, > > and KTLS is currently disabled by default anyway. > > > > Reviewed by: jhb > > MFC after: 1 week > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D29097 > > --- > > sys/kern/uipc_ktls.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/sys/kern/uipc_ktls.c b/sys/kern/uipc_ktls.c > > index 5125061e0879..1fd1eca39b59 100644 > > --- a/sys/kern/uipc_ktls.c > > +++ b/sys/kern/uipc_ktls.c > > @@ -495,7 +495,8 @@ ktls_init(void *dummy __unused) > > } > > } > > > > - printf("KTLS: Initialized %d threads\n", ktls_number_threads); > > + if (bootverbose) > > + printf("KTLS: Initialized %d threads\n", ktls_number_threads); > > } > > SYSINIT(ktls, SI_SUB_SMP + 1, SI_ORDER_ANY, ktls_init, NULL); > > > > _______________________________________________ > > dev-commits-src-main@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > > To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebsd.org" > > --