From owner-svn-src-all@FreeBSD.ORG Sun May 16 05:06:56 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 703FD106566B; Sun, 16 May 2010 05:06:56 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id DCCFE8FC12; Sun, 16 May 2010 05:06:55 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o4G575FX059128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 16 May 2010 08:07:05 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o4G56qoP048006; Sun, 16 May 2010 08:06:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o4G56pa9048005; Sun, 16 May 2010 08:06:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 16 May 2010 08:06:51 +0300 From: Kostik Belousov To: Zachary Loafman Message-ID: <20100516050651.GZ83316@deviant.kiev.zoral.com.ua> References: <201005122124.o4CLOk3b027904@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UEl6xVrmin0CpRyj" Content-Disposition: inline In-Reply-To: <201005122124.o4CLOk3b027904@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_40, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, matthew.fleming@isilon.com Subject: Re: svn commit: r208003 - in head/sys: kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 May 2010 05:06:56 -0000 --UEl6xVrmin0CpRyj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 12, 2010 at 09:24:46PM +0000, Zachary Loafman wrote: > Author: zml > Date: Wed May 12 21:24:46 2010 > New Revision: 208003 > URL: http://svn.freebsd.org/changeset/base/208003 >=20 > Log: > Add VOP_ADVLOCKPURGE so that the file system is called when purging > locks (in the case where the VFS impl isn't using lf_*) > =20 > Submitted by: Matthew Fleming > Reviewed by: zml, dfr After looking at what happen to nullfs, see r208003, I wonder why the vop is needed. It is called after VOP_RECLAIM is called by vgonel(), after fs-specific data are destroyed. So, on the one hand, vop can only operate on struct vnode proper, on the other hand, the actions performed by vop_advlockpurge implementation can be done by vop_reclaim as well. Could you, please, give some details on the supposed use of the vop ? --UEl6xVrmin0CpRyj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkvvfWoACgkQC3+MBN1Mb4gXLwCePdawtU3wzHF64fol/6T27b7I 7PgAn0mJbrA0eirA6wYJOpGV7nzaC2KF =E+dx -----END PGP SIGNATURE----- --UEl6xVrmin0CpRyj--