From owner-freebsd-hackers@FreeBSD.ORG Mon Dec 8 13:39:22 2014 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 10253EE8 for ; Mon, 8 Dec 2014 13:39:22 +0000 (UTC) Received: from nm38.bullet.mail.ir2.yahoo.com (nm38.bullet.mail.ir2.yahoo.com [212.82.96.63]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 753FC280 for ; Mon, 8 Dec 2014 13:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1418045953; bh=tnQ2+/O6b6NRI/3r8f46BDaiU1/x7AxUUFviAvab4Xo=; h=Date:From:Resent-From:Resent-Date:Resent-To:From:Subject; b=VPhu3fAei+G6QJUf5YyGH0FHzfbG0rcCpMxf21rqggIw05VwWPVN5JFW+vJIRMsLhw2dQigNh8vN6Y8i9kR4+VvIaHOxyNqO3aFEOpyuMV5RK6y8qTdtbPlPUimBeCeicbLpn2nbp1dG0Z2138rwo27wWlnYeOpN5+ZAmmsYZO1PoPLhOR1eH/ulENkG+HZ25LUeAMizsLDKdSMQMrVWdbY4viTEDKyn3pz3FmQDnGDdNZJ5SUaEp8+7aEg5ei7iWrXW4zdmwd4RY/ww57Rd3VfYDfE5sS2pjXWHkx6lrUj1UzVnpVLY1aflf9tSeXwmunkRHYvfIdtZTt4rrsg6yg== DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.com; b=Xe+vawyTDNPZna6Q9/PSsVJ44KhJYsF/MbYYNCK4OKdyIAmwjv8XC85lyrKv+lriiNp4LmpGIvSHgMRoze74I3320muvf/5dAQ3B5AyJ4tAPV96xSrWsCX6ynGsG19wjeLy08nYDIrZSImi24Clzf2020uglTMQ/0WAdP8QaX0NpGytc3aWj9q4jciRaV7K4nUY7jDbMojkcLWrhDC++L4qAqWWr+c4JjYUjoIBW0Q8Qird6RA1BfibebN7f2Di25WTqMBAVILgBcIak80zSvI5yAHeFowGGzGTTB8DP0KOyPuwVfdFu0S6S4Ltov/SIXYA9N3e7Qm7Wdsp5s+wuZA==; Received: from [212.82.98.55] by nm38.bullet.mail.ir2.yahoo.com with NNFMP; 08 Dec 2014 13:39:13 -0000 Received: from [46.228.39.88] by tm8.bullet.mail.ir2.yahoo.com with NNFMP; 08 Dec 2014 13:39:13 -0000 Received: from [127.0.0.1] by smtp125.mail.ir2.yahoo.com with NNFMP; 08 Dec 2014 13:39:13 -0000 X-Yahoo-Newman-Id: 133375.35515.bm@smtp125.mail.ir2.yahoo.com Message-ID: <133375.35515.bm@smtp125.mail.ir2.yahoo.com> Date: Mon, 8 Dec 2014 13:39:13 +0000 (UTC) X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: eTJCHWEVM1lRH79meJAmxg_1Mrcnlo0mhnBSuHVSw6aWe2j Fmi5B0dCbYViwYcjs0ClqyGBDohBMGKVAVj7uLem2v6GYnJhALE57YEzfEk5 Je4c.41_wn59HZeaDi5lSFenXc1IZT54ueY2WaIfeeZu.LmwAVzWVJBFaIPM 7Hdo.DtfqbMmAmInb3Z8aTNreJyjLThCj4VTfHpbf3RvJmyXf_NS3oKydlc7 .DzN2NQRs8ToeR8XHojsDVnEmvMNBaoqETb991wHcxB_moWfgG6bZc0C_pvf ZvWTtJTAMycNveSMbc6PZ31HUimkt.JNKf8wWsMg1CSoxImP2tOOgwvzQB6q iyAiEK.pJRpNRkMAfjuPGUwO9AuKLzlLjvmZKcaOM6JKjOlHj2dX7eqddAET _6OVFwtL2bicaRQz.fkMxtp822Uhh_asikIkVzUk_NKDVCrNlaE251vK420x tn297ipxbBTKlCMcUMoO6UIAH1n_oi9Ji7us4ReVbABO2Q75Ui9kNO6nCctG L3S_m8wa4BlPGfwyyO9O7ITuPr8pAsIs- X-Yahoo-SMTP: iDf2N9.swBDAhYEh7VHfpgq0lnq. From: se@freebsd.org Received: by StefanEsser.freebsd.org (Postfix, from userid 200) id 174C8701; Mon, 8 Dec 2014 14:39:12 +0100 (CET) Resent-From: Stefan Esser Resent-Date: Mon, 8 Dec 2014 14:39:12 +0100 Resent-Message-ID: <20141208133912.GA21370@StefanEsser.freebsd.org> Resent-To: hackers@freebsd.org, phil@juniper.net X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2014 13:39:22 -0000 >From se@FreeBSD.org Mon Dec 8 14:34:01 2014 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on StefanEsser.freebsd.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=7.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RDNS_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 X-Original-To: se@localhost Received: from StefanEsser.freebsd.org (localhost [IPv6:::1]) by StefanEsser.freebsd.org (Postfix) with ESMTP id 814C66FF for ; Mon, 8 Dec 2014 14:34:01 +0100 (CET) Received: from sfwdallmx.t-online.de [194.25.134.46] by StefanEsser.freebsd.org with POP3 (fetchmail-6.3.26) for (single-drop); Mon, 08 Dec 2014 14:34:01 +0100 (CET) Received: from mailin58.aul.t-online.de ([172.20.27.247]) by ehead603.aul.t-online.de (Dovecot) with LMTP id DS1GDYOmhVQ+LAAAPh7MgA; Mon, 08 Dec 2014 14:24:19 +0100 Received: from mx2.freebsd.org ([8.8.178.116]) by mailin58.aul.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1XxyIT-2JxvX60; Mon, 8 Dec 2014 14:24:17 +0100 Received: from hub.freebsd.org (hub.freebsd.org [8.8.178.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.freebsd.org (Postfix) with ESMTPS id 37D5B373A for ; Mon, 8 Dec 2014 13:24:15 +0000 (UTC) Received: by hub.freebsd.org (Postfix) id 35023C52; Mon, 8 Dec 2014 13:24:15 +0000 (UTC) Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 34387C50 for ; Mon, 8 Dec 2014 13:24:15 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F2034146 for ; Mon, 8 Dec 2014 13:24:14 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id sB8DOEcg056293 for ; Mon, 8 Dec 2014 13:24:14 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id sB8DOE39056292; Mon, 8 Dec 2014 13:24:14 GMT (envelope-from root) Date: Mon, 8 Dec 2014 13:24:14 +0000 To: se@localhost.FreeBSD.org From: =?utf-8?Q?se_=28Stefan_E=C3=9Fer=29?= Subject: [Differential] [Updated, 639 lines] D1206: Add libxo support to pciconf Message-ID: <75337b9bc584b5c3795df4e0b12641ad@localhost.localdomain> X-Priority: 3 Thread-Topic: D1206: Add libxo support to pciconf X-Herald-Rules: none X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NmM1NGY4YmRhNzU1ODBkMDBiYjdjMTRhYWQ3IFSFpn4= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-TOI-SPAM: u;0;2014-12-08T13:24:19Z X-TOI-VIRUSSCAN: unchecked X-TOI-MSGID: abfdb5d0-3bcc-4171-8a83-0d818bff93ab X-Seen: false X-ENVELOPE-TO: X-UID: 182952 X-Keywords: NonJunk se updated this revision to Diff 2680. se added a comment. Update after review by Phil Shafer and extend to cover errors and capabilities Summary: This version contains many fixes to issues pointed out by Phil and a number of further enhancements: - Use of XO lists and instances to structure the information - Descriptive identifiers instead of abbreviations - Addition of XO support to PCI/PCIe error reporting - Addition of XO support to PCI/PCIe capability information printing I do not have access to a PCI or PCI-Express Spec. with information on the capabilities and their specified names, but have only used publicly available information to select XML/JSON labels. A pointer to a freely available specification of PCI/PCIe capabilities (just the path that might help chose good names for data fields) would be highly appreciated. Test Plan: This version of pciconf should generate 100% identical output, except when one of the structured XO formats is requested. Please test with: pciconf -lbecv I do not know whether the labels used for XML amd JSON output of PCI/PCIe capabilities are well chosen. Several names are very long, but I wanted to avoid cryptic abbreviations. Suggestions for better or more correct names are welcome. I could not test output of Intel or AMD (Hyper Transport) specific capabilities (my Intel system uses SATA AHCI, but I do not see that in the reported capabilities; I do not have any FreeBSD systems on AMD hardware, currently). I'm adding a few reviewers (jhb because he did the initial commit of cap.c and kib because of the HT specific information that I cannot test). I hope you don't mind being selected as potential reviewers. Reviewers: phil@juniper.net hackers@freebsd.org jhb@freebsd.org kib@freebsd.org Subscribers: CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1206?vs=2617&id=2680 REVISION DETAIL https://reviews.freebsd.org/D1206 AFFECTED FILES Makefile cap.c err.c pciconf.c To: se Cc: emaste