Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Aug 2020 23:35:14 +0200
From:      Mateusz Piotrowski <0mp@FreeBSD.org>
To:        Olivier Cochard <olivier@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r544108 - in head/net: . read_bbrlog
Message-ID:  <7a8ee5e3-f4f8-7d95-7517-3d35ed66aa8b@FreeBSD.org>
In-Reply-To: <202008032040.073Ke7MH047469@repo.freebsd.org>
References:  <202008032040.073Ke7MH047469@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Olivier!

On 8/3/20 10:40 PM, Olivier Cochard wrote:
> Author: olivier
> Date: Mon Aug  3 20:40:06 2020
> New Revision: 544108
> URL: https://svnweb.freebsd.org/changeset/ports/544108
>
> Log:
>    New port: net/read_bbrlog
...
> Added: head/net/read_bbrlog/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/net/read_bbrlog/Makefile	Mon Aug  3 20:40:06 2020	(r544108)
> @@ -0,0 +1,38 @@
> +# $FreeBSD$
> +
> +PORTNAME=	read_bbrlog
> +PORTVERSION=	0.1.1
> +DISTVERSIONPREFIX=	v
> +CATEGORIES=	net
> +
> +MAINTAINER=	olivier@FreeBSD.org
> +COMMENT=	Decode BBR log dumps generated with tcplog_dumper
> +
> +LICENSE=	BSD2CLAUSE
> +LICENSE_FILE=	${WRKSRC}/LICENSE
> +
> +ONLY_FOR_ARCHS=	amd64
> +
> +BUILD_DEPENDS=	${PREFIX}/include/bbparse.h:devel/bbparse
> +
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	Netflix
> +
> +PLIST_FILES=	bin/read_bbrlog \
> +		man/man1/read_bbrlog.1.gz
Keep in mind that we are slowly moving towards share/man/man1.
> +
> +CFLAGS+=	-I${PREFIX}/include
> +LDFLAGS+=	-L${PREFIX}/lib

This should probably be LOCALBASE instead of PREFIX. Maybe this could be replaced with 
USES=localbase:ldflags?

Cheers,

Mateusz Piotrowski




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7a8ee5e3-f4f8-7d95-7517-3d35ed66aa8b>