From owner-freebsd-usb@FreeBSD.ORG  Sun Mar  1 19:25:57 2009
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: usb@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2F6EF1065676
	for <usb@FreeBSD.org>; Sun,  1 Mar 2009 19:25:57 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226])
	by mx1.freebsd.org (Postfix) with ESMTP id E73608FC22
	for <usb@FreeBSD.org>; Sun,  1 Mar 2009 19:25:56 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from localhost (localhost [127.0.0.1])
	by pele.citylink.co.nz (Postfix) with ESMTP id ED7E5FFA2;
	Mon,  2 Mar 2009 08:25:55 +1300 (NZDT)
X-Virus-Scanned: Debian amavisd-new at citylink.co.nz
Received: from pele.citylink.co.nz ([127.0.0.1])
	by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id VbNAHYiwx3c7; Mon,  2 Mar 2009 08:25:52 +1300 (NZDT)
Received: from citylink.fud.org.nz (unknown [202.8.44.45])
	by pele.citylink.co.nz (Postfix) with ESMTP;
	Mon,  2 Mar 2009 08:25:52 +1300 (NZDT)
Received: by citylink.fud.org.nz (Postfix, from userid 1001)
	id C56B81142F; Mon,  2 Mar 2009 08:25:51 +1300 (NZDT)
Date: Sun, 1 Mar 2009 11:25:51 -0800
From: Andrew Thompson <thompsa@FreeBSD.org>
To: "M. Warner Losh" <imp@bsdimp.com>
Message-ID: <20090301192551.GA57940@citylink.fud.org.nz>
References: <ACB7DFF1-6C8E-4936-9BD9-BB2FD375F3BB@mac.com>
	<20090301190057.GD90301@citylink.fud.org.nz>
	<20090301.121620.-2073256982.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090301.121620.-2073256982.imp@bsdimp.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: usb@FreeBSD.org
Subject: Re: USB2+umass: root mount fails
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Mar 2009 19:25:57 -0000

On Sun, Mar 01, 2009 at 12:16:20PM -0700, M. Warner Losh wrote:
> In message: <20090301190057.GD90301@citylink.fud.org.nz>
>             Andrew Thompson <thompsa@freebsd.org> writes:
> : On Mon, Feb 16, 2009 at 01:53:36PM -0800, Marcel Moolenaar wrote:
> : > It appears that the root mount isn't serialized with USB discovery
> : > in the same way it was under USB1.
> : 
> : It seems that this is not completly resolved with the root mount hold in
> : r188907 as geom may not have tasted the partition tables when
> : vfs_rootmount is woken. USB still needs to finish its bus probe earlier
> : on the boot process.
> 
> This sounds like a more fundamental ordering problem.  It sounds like
> we need two gates here.  (1) All the underlying devices are there and
> (2) All tasting is done.

So should another root hold token be grabbed in disk_create() and
released on taste?

Andrew