From owner-svn-src-all@freebsd.org Sun Apr 7 17:34:54 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 892DA1565CAC for ; Sun, 7 Apr 2019 17:34:54 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1D7466AB67 for ; Sun, 7 Apr 2019 17:34:54 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt1-x841.google.com with SMTP id p20so12846682qtc.9 for ; Sun, 07 Apr 2019 10:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UAbBekVDhxJT5CSdvsfCRbrg25l68MYS2PLzE7bYqYs=; b=P4kVY65Fod6ExxQrPEL8b6rY6Khu8pb4sKHM9Ry4S9CGSNgH6O+psfRNNOykDUsBsl pblCu9BxQMxmHE5yuy0KOg7y3MTWy08MNUKZya+Pg1U7PWV3zTU3yqS2YaC6tU7kPuvg UnBQdPxbBebgsK9unZO/5mc2s85a0cZHPeVaOrfV2pHSjVBWjcv23OLDp3++pnJo6/HB usbC0cUOHgpyPkRxeg/fpErqnErWM6LgnMHvXGw1fNar49W80bbtEIk3AFhyfbc5pjiQ Fa65kh/van6zZaVIZwI+S1Wl+yTX58JmZZCUXebntWtjX7kf9HtfuEKWgWshDhepatJR p1pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UAbBekVDhxJT5CSdvsfCRbrg25l68MYS2PLzE7bYqYs=; b=BnBYF4EugY23T7faE5Fuvml1Jw+AdvCdGVbbhpVxUiPy9cbOvObS23EwDvY6R5WdM/ c9qwwr/+HRHJFXNI+IvZQjE+7jqmN+LCWoNnMRzXK9IHiQlYg4qPHzuz5tzb8nx1kPlT fWAVNudYsKUdTvLgz0IyVuqe8nsZPG2OBSfGPPaNhgggA/tQ2BZ0odLyeltH7jqiTHaE dV3i22nVXKS/5z7I2/rjDrg03zzrqsSYdaffrhi7m4DUali9uL+TaHn4+ag6d4W5zPmo AFCzh3t83o7puIKi19dzK9r7+fv6n6vwRlPQJ4b2i30oLKWMDCEPZ2piglV7r2xioVqR C4sA== X-Gm-Message-State: APjAAAXYU+bjTqz86/x0HUNwmdbDqKGu2weZ0Lp2+t8+aJAi1F/dkqUA DO1KYVY5j4fNrFzp3I8KKS+2XA== X-Google-Smtp-Source: APXvYqw2Ikz4Y26A1HGK1B+HUfeskC76s4TOhgT+mj5dqAvTh0uAhOjkzkfHlQep4KT1K0yHJXvJFw== X-Received: by 2002:ac8:38f5:: with SMTP id g50mr20013847qtc.119.1554658493581; Sun, 07 Apr 2019 10:34:53 -0700 (PDT) Received: from mutt-hbsd ([151.196.118.239]) by smtp.gmail.com with ESMTPSA id x24sm4619410qtm.65.2019.04.07.10.34.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Apr 2019 10:34:52 -0700 (PDT) Date: Sun, 7 Apr 2019 13:33:59 -0400 From: Shawn Webb To: Mariusz Zaborski Cc: Cy Schubert , rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345982 - in head: include lib/libc/sys sys/cddl/compat/opensolaris/sys sys/compat/cloudabi sys/compat/freebsd32 sys/compat/linux sys/kern sys/sys sys/ufs/ffs Message-ID: <20190407173359.vc2fwmnsbky7dlkj@mutt-hbsd> References: <201904071510.x37FA7tm050626@gndrsh.dnsmgr.net> <201904071535.x37FZ7bk073860@slippy.cwsent.com> <20190407161158.GA40247@x-wing> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h5gs4klk52ndinq6" Content-Disposition: inline In-Reply-To: <20190407161158.GA40247@x-wing> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD r345948+db88569731b7(hardened/current/master) HARDENEDBSD-13-CURRENT amd64 X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 1D7466AB67 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.973,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Apr 2019 17:34:54 -0000 --h5gs4klk52ndinq6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable No worries. Thanks for the correction! --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 On Sun, Apr 07, 2019 at 06:11:58PM +0200, Mariusz Zaborski wrote: > In the https://wiki.freebsd.org/AddingSyscalls we mentions that we need t= o bump > __FreeBSD_version. I confirmed that with Warner. So this was my mistake. >=20 > Thanks Shawn. > --=20 > Mariusz Zaborski > oshogbo//vx | http://oshogbo.vexillium.org > FreeBSD committer | https://freebsd.org > Software developer | http://wheelsystems.com > If it's not broken, let's fix it till it is!!1 >=20 > On Sun, Apr 07, 2019 at 08:35:07AM -0700, Cy Schubert wrote: > > In message <201904071510.x37FA7tm050626@gndrsh.dnsmgr.net>, "Rodney W.= =20 > > Grimes" > > writes: > > > > On April 7, 2019 7:11:52 AM PDT, Shawn Webb wr > > > ote: > > > > >On Sat, Apr 06, 2019 at 09:34:26AM +0000, Mariusz Zaborski wrote: > > > > >> Author: oshogbo > > > > >> Date: Sat Apr 6 09:34:26 2019 > > > > >> New Revision: 345982 > > > > >> URL: https://svnweb.freebsd.org/changeset/base/345982 > > > > >>=20 > > > > >> Log: > > > > >> Introduce funlinkat syscall that always us to check if we are > > > > >removing > > > > >> the file associated with the given file descriptor. > > > > >> =20 > > > > >> Reviewed by: kib, asomers > > > > >> Reviewed by: cem, jilles, brooks (they reviewed previous versi= on) > > > > >> Discussed with: pjd, and many others > > > > >> Differential Revision: https://reviews.freebsd.org/D14567 > > > > > > > > > >Hey Mariusz, > > > > > > > > > >Is __FreeBSD_version supposed to be bumped after adding new syscal= ls? > > > > >I can't remember off-hand. > > > > > > > > > >Thanks, > > > >=20 > > > > I don't think so. Why force the rebuild of all ports through poudri= ere over > > > something that would never affect any of them? > > > > > > So that you can if version >=3D foo to know it is safe to use the new= syscal? > > > Or if version < foo you must use the old way. > >=20 > > Granted. However we do need something to avoid gratuitous rebuilds of= =20 > > ports. > >=20 > > Personally, my poudriere script adjusts the pkg version=20 > > ($JAILPATH/data/packages/${JAIL}-${PORTS}/.building/.jailversion) with= =20 > > that of the jail version (reported by poudriere jail -i -j $JAIL),=20 > > rebuilding all ports when I (the human) determines when the machine=20 > > should rebuild all ports with -c. > >=20 > > In that regard FreeBSD version bumps occasionally seem a little=20 > > gratuitous. Using the same indicator to tell whether software should be= =20 > > able to use a new feature and when ports build infrastructure should=20 > > summarily delete all packages forcing a rebuild of absolutely=20 > > everything is probably not the best. > >=20 > > Just throwing out an idea, what if poudriere considers the first N=20 > > bytes of __FreeBSD_version significant? Having said that, looking at=20 > > __FreeBSD_version, I don't think we have enough digits to do what I was= =20 > > planning on suggesting. But, you get the idea of what I'm driving at.= =20 > > Maybe a new macro such as __FreeBSD_ports that is incremented every=20 > > time a change that affects ports? > >=20 > > Anyhow, I'm not too terribly concerned as what I have (selfishly=20 > > speaking) works. But we may as a group might want to consider this at= =20 > > some point to build some efficiency into the ports part of the equation. > >=20 > >=20 > > --=20 > > Cheers, > > Cy Schubert > > FreeBSD UNIX: Web: http://www.FreeBSD.org > >=20 > > The need of the many outweighs the greed of the few. > > =20 > >=20 --h5gs4klk52ndinq6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAlyqNIAACgkQ/y5nonf4 4fr28xAAh1pFG/uwPHj1IgEn40Dm66GilPg84s02U2zbRzmV3rfCXK7jeN2yysVm eKZCzJtrdyXZeG7syqibhGvNRaIYcxXcStQFWl+G2qT/iPpLw9PdJI987TzRyKqY uXX8Stxsc7g1Nz/48HD7aXXv6wa42SXO2XNSlOR4o6S0lh2hKefYFteD2ftSoMK6 JT7+yCLzQJQU0BIvP4kT/FPMSfg/eCjR1FqGOXVkv4VygaVGoP3QUs4VAszwbh9E inBl8oQr2jZF9w09OlHf7w5vSp0vYhs34McIi4BonyaEhUz7jjNZ6BdbjOrwo85g o28/agMPeDvP25mM3Ifyn2F9U8etM2Y4WrPyIc8fYPSuCxgfTpnfiF2dN74t6Epc mzbwickapoadulnEeCIW/Z9R/FS5TTiGgkKl7u7YKL8QDZu96gjJn8PBsSDy4PaH 9j+8MEaz0J4eiAU+SEySrTU2GWW6RuzbZ6hymVXLlNzZfpG3Z9oRNgOD41dG+Y49 /3pF9ZhL2XLMTMxDZLPGSyv9AbOijTdmzZuTTj9U2/Ei2DT4Yyy0+zp1iOlpy9dg LHq5Nvztuk9yA7Ig25s6952CseuvjnscJ/5yHng2QPdGpEXcme9lY1yjZF/70tn5 MZGYo38hr6kwnLHTJ38ucw2FT+uV2cPuzKbwqxW31eOuI1T7gyM= =K2n/ -----END PGP SIGNATURE----- --h5gs4klk52ndinq6--