From nobody Sun May 18 20:23:03 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b0shD2LKpz5wn00; Sun, 18 May 2025 20:23:08 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b0shC6Cckz4JW4; Sun, 18 May 2025 20:23:07 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-6f8b0fdd5ffso33688356d6.0; Sun, 18 May 2025 13:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747599786; x=1748204586; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=fMujNrHIfrUFrmE4CNM/PSjTKf9QrHzWOQ8pA+v3swk=; b=cVtg3bIKw6vkLTmK71/nxrPFKe4rF/PsWrkymUH0vbBFlB6BSjBFfRd8UwF3OnyGmC mMSmfp3CdRQLtZ+09dbMl8OTWjDHYW+Dx3TiPqKOE6+u/nm7JOu3MxagcBUEsz/WbCfN rwsInIwht0+LItVgGC+5dm4yQe8InQCGoQVo87q2B5dcE6kTgyZ4dvq1dtunhIQ+JJwI DO1dZxhG/nntikr6ppypS97bpNWaxoKfxlTXGYQUst9UGPCAE9t1X3UF6/oHXot6gt88 lamOGbW/YQK08GP8wZN9vrLku1wKcnv62hBeSbA3++KMhcZymUNSSRijYToDJZXHTB0z +qfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747599786; x=1748204586; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fMujNrHIfrUFrmE4CNM/PSjTKf9QrHzWOQ8pA+v3swk=; b=c1QUfTTYChEg/+T4np5gy8EoCG0KpcwKhv5QQ/YCiNCulwnxaeBUvZcc0sHTwZs8lF a3FBRZ7c50nTv3nM/EwMHzpHb1l4tqnZxa9IhVILAGHNHmxhRism8DBe1FgJzq65acqd EHd0YQOzCogj6+W8r4v3e+5HofoJedGcKblhZUqvhKaCT4IQ/8X2oPwdrVMprHDMpTLz pk/lPpkFjbXXns7q97nmAJZyvF4aa9KvafsC/eCQ2ZipJwnSm1ZkReFz638fFenHgPfD QqGdiH18Uo25Bz4Zv4rU+5iCs6M0gLXyhPiUbnpeuuWBMkS4iWZfq6bgFVtw+aMuVV8M 4M5A== X-Forwarded-Encrypted: i=1; AJvYcCUMnWK59EChn6uu4Z41c9LkegD5N2XrsqKv8uZjmIFU23vdgpYZtinabjN4c1yRJFsf/CQJegJP2EUt1stPXlc=@freebsd.org, AJvYcCUfMUtxeJFeVxSNBm2HnrNKrOnNyLrwpwkf6neG7P3wrufhiFIZ1eOCsmliXrW2Airi6HL3gmYyUZBVrrMv0wI9+tKS@freebsd.org, AJvYcCV+s4BFYS1jVD2mX8NtA9/X97M+y2MDk4wV2KmTXnb9PMa2nysFTpnPPPgfkaP1Wt23zWgh@freebsd.org, AJvYcCVIJcx+XVhZojumr6n9HmTEuHkTK+vLBib2ze2bTfniuTZugeITMTqVA57LrV/zpCwn8fTWm4IO1V9RwndSZvqFazfF+5A=@freebsd.org X-Gm-Message-State: AOJu0YwmC2smUuunib/2tjtLs2Wxquo8ki6uW7Vc10jJ3DOxIkH0VzZC eQ5lFtFIEyQjy/o8WnkEjy7vZm6Y2T/Tc2M7IwQyTIRnzqTfsFhJJ9FlxD0252I5 X-Gm-Gg: ASbGnctq5+JBFP1E3BnfJeLwJ+tDX+C5dMI964c7oQIlSVxpftZCeTSeoDnpViQ6Q+E JwQ2OcpR4YjIV0GiiCv5/uz7y94KaeB1gfF5YvFZHXpQG0UA/h8sNjqItAJ2DkkEG9C8HWOj3qo OVtTL/OzlzrGmwOpFvrgmJs0uYcqISRVVjEtErFNe2I5nI99zQbyH3T2xK8OscYP02xx43oWR7+ Dbr6MsXdaZ01O7qIwLTxoS1GYG3fUEF2ZaCcPjVYRplbBSBVXvmkUyznUhjOylw7fcK1ANRgkMy agVyTUHBnwqWvs7I3TXi1PuDwnvZTIbV5RG5r4xvgOIWpul5fAJ0W5gv8LKIS/pEjw== X-Google-Smtp-Source: AGHT+IGSebZhZU1ceMGD5a1GDgojv8Xyx6AEoMmtaXjVFnKEAVs+DAu1eAD+5aBK3DVLm39pK871iw== X-Received: by 2002:ad4:5f8e:0:b0:6ef:3de:5ff7 with SMTP id 6a1803df08f44-6f8b0866722mr188771766d6.15.1747599786571; Sun, 18 May 2025 13:23:06 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f8b0966098sm45079786d6.82.2025.05.18.13.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 May 2025 13:23:06 -0700 (PDT) Date: Sun, 18 May 2025 16:23:03 -0400 From: Mark Johnston To: Jessica Clarke Cc: Mitchell Horne , Lexi Winter , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: b61850c4e6f6 - main - bridge(4): default net.link.bridge.member_ifaddrs to false Message-ID: References: <202505150004.54F04FhR046897@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4b0shC6Cckz4JW4 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Spamd-Bar: ---- On Sun, May 18, 2025 at 07:53:14PM +0100, Jessica Clarke wrote: > On 17 May 2025, at 22:18, Mitchell Horne wrote: > > On 5/14/25 21:04, Lexi Winter wrote: > >> The branch main has been updated by ivy: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=b61850c4e6f6b0f21b36da7238db969d9090309e > >> > >> commit b61850c4e6f6b0f21b36da7238db969d9090309e > >> Author: Lexi Winter > >> AuthorDate: 2025-05-14 14:26:24 +0000 > >> Commit: Lexi Winter > >> CommitDate: 2025-05-15 00:02:52 +0000 > >> > >> bridge(4): default net.link.bridge.member_ifaddrs to false > >> > >> As discussed on arch@, this behaviour is broken and confuses users, so > >> disable it by default. For 15.0-RELEASE, allow it to be re-enabled > >> using a sysctl, but the sysctl will be removed in 16.0R. > >> > > > > Hi Lexi, > > > > I just updated my workstation past this commit. I found that my main > > ethernet interface didn't receive an IP address, and had to set the > > sysctl to proceed as before. > > > > I have the following network configuration lines in my rc.conf: > > > > ifconfig_re0="DHCP" > > cloned_interfaces="bridge0 tap0" > > ifconfig_bridge0="addm re0 addm tap0 up" > > I also have a setup like this, as I suspect many do. I do too. > The handbook even > gives this configuration in places[1] (though note it’s inconsistent in > whether the interface or bridge should have the address). The lack of > interaction with devd to automatically run dhclient as re0 comes and > goes is also rather sucky, especially if re0 is wlan0. I appreciate > that there may well be good technical reasons why this shouldn’t be > what people do, but (a) it is for specifically this case and I think > it’s a bit shortsighted to go and break something we still document > today as correct (b) the UX needs improving specifically for bridging a > real interface to one or more tap ones before we enforce this. I agree. Even if the setup is broken in some way, it works fine for simple cases and this will be a nasty surprise when upgrading. It would be much better IMO to print a warning and let users fix their configuration before flipping the default. That is how we handled interface address configuration without a netmask: commit d8237b955528 added a warning, and some time later it was turned into a fatal error. I really think it would be better to do something similar here.