From owner-cvs-all@FreeBSD.ORG  Thu Aug  3 12:05:20 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9ED4216A4DE;
	Thu,  3 Aug 2006 12:05:20 +0000 (UTC)
	(envelope-from simon@zaphod.nitro.dk)
Received: from mx.nitro.dk (zarniwoop.nitro.dk [83.92.207.38])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B80D543D53;
	Thu,  3 Aug 2006 12:05:19 +0000 (GMT)
	(envelope-from simon@zaphod.nitro.dk)
Received: from zaphod.nitro.dk (unknown [192.168.3.39])
	by mx.nitro.dk (Postfix) with ESMTP id 936EF2D8503;
	Thu,  3 Aug 2006 12:05:17 +0000 (UTC)
Received: by zaphod.nitro.dk (Postfix, from userid 3000)
	id 6EAFB1141D; Thu,  3 Aug 2006 14:05:16 +0200 (CEST)
Date: Thu, 3 Aug 2006 14:05:16 +0200
From: "Simon L. Nielsen" <simon@FreeBSD.org>
To: Poul-Henning Kamp <phk@FreeBSD.org>
Message-ID: <20060803120515.GA1223@zaphod.nitro.dk>
References: <200607131406.k6DE6Agl026625@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200607131406.k6DE6Agl026625@repoman.freebsd.org>
User-Agent: Mutt/1.5.11
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/tools/tools/nanobsd nanobsd.sh
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2006 12:05:20 -0000

On 2006.07.13 14:06:10 +0000, Poul-Henning Kamp wrote:
> phk         2006-07-13 14:06:10 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     tools/tools/nanobsd  nanobsd.sh 
>   Log:
>   Create the diskless magic files in /etc during the install_etc() step
>   instead of setup_nanobsd(), because this gives customize tasks a chance
>   to fiddle the details.

This makes it a bit harder to (ab)use nanobsd.sh as a framework to
build more normal FreeBSD images where a normal /etc is used.
Previously I simply replaced setup_nanobsd in my customize script and
I got a pretty standard FreeBSD install out in the end.

Would you mind if I split the "diskless" magic out into
setup_nanobsd_etc() (the parts code you moved in this commit) and then
run it right after install_etc()?  It shouldn't make a difference for
normal NanoBSD use, but then I can simply override setup_nanobsd_etc()
in my cutomize script and avoid larger patches against nanobsd.sh.

-- 
Simon L. Nielsen